state: add Machine.HasVote

state: add Machine.HasVote

This allows the peergrouper worker to report
the current voting status of machines.
We also change Destroy so that it will
not destroy a machine that is currently voting.

https://code.launchpad.net/~rogpeppe/juju-core/494-state-hasvote/+merge/205010

(do not edit description out of merge proposal)

[rog, 2014-02-05 17:17:36]

Please take a look.

[dimitern, 2014-02-05 17:35:37]

LGTM

https://codereview.appspot.com/50590045/diff/20001/state/machine_test.go
File state/machine_test.go (right):

https://codereview.appspot.com/50590045/diff/20001/state/machine_test.go#newc...
state/machine_test.go:267: c.Assert(err, gc.ErrorMatches, "machine [0-9]+ is a
voting replica set member")
You could use just .* instead of [0-9]+, or perhaps better, "machine "+id+"
...", where id := s.machine.Id().

[rog, 2014-02-05 17:49:53]

Please take a look.

https://codereview.appspot.com/50590045/diff/20001/state/machine_test.go
File state/machine_test.go (right):

https://codereview.appspot.com/50590045/diff/20001/state/machine_test.go#newc...
state/machine_test.go:267: c.Assert(err, gc.ErrorMatches, "machine [0-9]+ is a
voting replica set member")
On 2014/02/05 17:35:38, dimitern wrote:
> You could use just .* instead of [0-9]+, or perhaps better, "machine "+id+"
> ...", where id := s.machine.Id().

Done.