Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1822)

Issue 4974046: Make #{ #} accept everything an assignment accepts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 10 months ago
Reviewers:
nicolas.sceaux
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make #{ #} accept everything an assignment accepts. This also makes #{ #} return a void music event, and does not create sequential music if not necessary.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move parse-string-result into ly:parse-string-expression. #

Patch Set 3 : Fix EOF warning in lexer.ll #

Patch Set 4 : Document #{ ... #} functionality and its new uses. Patch countdown? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -48 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 3 11 chunks +61 lines, -25 lines 0 comments Download
M input/regression/display-lily-tests.ly View 1 1 chunk +1 line, -3 lines 0 comments Download
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/lily-parser.hh View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/lexer.ll View 1 2 3 chunks +21 lines, -4 lines 0 comments Download
M lily/lily-parser.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M lily/lily-parser-scheme.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M lily/parser.yy View 1 6 chunks +39 lines, -7 lines 0 comments Download
M scm/parser-ly-from-scheme.scm View 1 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 5
nicolas.sceaux
Hi David, This is so cool! and smart. http://codereview.appspot.com/4974046/diff/1/scm/parser-ly-from-scheme.scm File scm/parser-ly-from-scheme.scm (right): http://codereview.appspot.com/4974046/diff/1/scm/parser-ly-from-scheme.scm#newcode36 scm/parser-ly-from-scheme.scm:36: (ly:parser-lookup ...
7 years, 10 months ago (2011-08-28 08:45:19 UTC) #1
dak
This passes regtests. I would tend towards committing in this form in order to keep ...
7 years, 10 months ago (2011-08-28 12:01:35 UTC) #2
dak
Ok, I guess this is as good as it gets. I've put in some uses ...
7 years, 10 months ago (2011-08-28 16:11:21 UTC) #3
dak
I have decided to be an ass and push this change. It touches astonishingly little ...
7 years, 10 months ago (2011-08-28 20:00:14 UTC) #4
dak
7 years, 10 months ago (2011-08-29 04:29:51 UTC) #5
Graham Percival <graham@percival-music.ca> writes:

> On Sun, Aug 28, 2011 at 08:00:14PM +0000, dak@gnu.org wrote:
>> It would be a pity not to make it available to users.
>
> Do you want to dump something in changes.tely to let users know
> about this?

Good idea.  Consider it done yesterday.

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b