Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 4973062: code review 4973062: url: handle ; in ParseQuery (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

url: handle ; in ParseQuery Most web frameworks allow ; as a synonym for &, following a recommendation in some versions of the HTML specification. Do the same. Remove overuse of Split. Move ParseQuery tests from package http to package url. Fixes issue 2210.

Patch Set 1 #

Patch Set 2 : diff -r 78a08b9c6d48 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56fb1fd74279 https://go.googlecode.com/hg #

Patch Set 4 : diff -r ce2e5f44b310 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -67 lines) Patch
M src/pkg/http/request_test.go View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
M src/pkg/url/url.go View 1 1 chunk +19 lines, -11 lines 0 comments Download
M src/pkg/url/url_test.go View 1 2 2 chunks +57 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
10 years, 4 months ago (2011-09-06 14:18:11 UTC) #1
r
LGTM
10 years, 4 months ago (2011-09-06 14:50:23 UTC) #2
rsc
10 years, 4 months ago (2011-09-06 16:24:29 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=db925aedad3d ***

url: handle ; in ParseQuery

Most web frameworks allow ; as a synonym for &,
following a recommendation in some versions of
the HTML specification.  Do the same.

Remove overuse of Split.

Move ParseQuery tests from package http to package url.

Fixes issue 2210.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4973062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b