Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Unified Diff: mf/feta-noteheads.mf

Issue 4931043: include lines in breve X-extent (issue 1814) (Closed)
Patch Set: Created 12 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mf/feta-noteheads.mf
diff --git a/mf/feta-noteheads.mf b/mf/feta-noteheads.mf
index a58e4bc89a7a6c607a3da1dea2478ecce9b8ba0f..1c208b651d9a248bb48b10deb05c3ff63d4c11d5 100644
--- a/mf/feta-noteheads.mf
+++ b/mf/feta-noteheads.mf
@@ -164,6 +164,11 @@ def draw_brevis (expr linecount, line_thickness_multiplier) =
define_whole_blacker_pixels (stemthick);
% Breves of smaller design sizes should have their lines
+ % farther apart.
+ gap# := (0.95 - 0.008 * design_size) * stemthick#;
Bertrand Bordage 2011/08/25 15:03:04 You should save gap, line 161.
janek 2011/09/06 08:54:40 Done.
+ define_pixels (gap);
Bertrand Bordage 2011/08/25 15:03:04 This should be moved after set_char_box.
janek 2011/09/06 08:54:40 Done.
+
+ % Breves of smaller design sizes should have their lines
% farther apart (the overlap should be smaller).
fudge = hround (blot_diameter
* min (max (-0.15,
@@ -175,6 +180,11 @@ def draw_brevis (expr linecount, line_thickness_multiplier) =
draw_outside_ellipse (1.80, 0, 0.707, 0);
undraw_inside_ellipse (1.30, 125, 0.68, 2 stafflinethickness#);
+ set_char_box (stemthick# * linecount + gap# * (linecount - 1),
Keith 2012/05/09 06:03:40 Jan, the breves seem to be the only note-heads tha
+ width# + stemthick# * linecount + gap# * (linecount - 1),
+ noteheight# / 2,
+ noteheight# / 2);
+
pickup pencircle scaled stemthick;
% Breves of smaller design sizes should have their lines longer.
@@ -194,20 +204,17 @@ def draw_brevis (expr linecount, line_thickness_multiplier) =
rt x1 - fudge = 0;
x1 = x2;
- fudge + lft x3 = w;
+ fudge + lft x3 = width;
x4 = x3;
y4 = y2;
y3 = y1;
- % Breves of smaller design sizes should have their lines
- % farther apart.
- line_distance := (1.95 - 0.008 * design_size) * stemthick;
for i := 0 step 1 until linecount - 1:
- draw_gridline (z1 - (i * line_distance, 0),
- z2 - (i * line_distance, 0),
+ draw_gridline (z1 - (i * (gap + stemthick), 0),
Bertrand Bordage 2011/08/25 15:03:04 Hmmm... Don't you think (i * (gap + stemthick), 0)
janek 2011/09/06 08:54:40 I'm not sure what you mean. Are you saying that i
+ z2 - (i * (gap + stemthick), 0),
stemthick);
- draw_gridline (z3 + (i * line_distance, 0),
- z4 + (i * line_distance, 0),
+ draw_gridline (z3 + (i * (gap + stemthick), 0),
+ z4 + (i * (gap + stemthick), 0),
stemthick);
endfor;
enddef;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b