Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(396)

Issue 4931043: include lines in breve X-extent (issue 1814) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by Janek Warchol
Modified:
7 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

include lines in breve X-extent (issue 1814) char box of breve glyphs is widened to include the lines, not only notehead. This will allow Lily to calculate collisions with breves correctly. It shouldn't change how breves are aligned in note columns.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M mf/feta-noteheads.mf View 3 chunks +15 lines, -8 lines 7 comments Download

Messages

Total messages: 13
janek
7 years, 10 months ago (2011-08-23 22:16:36 UTC) #1
Bertrand Bordage
Just a quick review. Bertrand
7 years, 10 months ago (2011-08-25 15:02:33 UTC) #2
Bertrand Bordage
Sorry, I forgot to send the comments. http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode168 mf/feta-noteheads.mf:168: gap# := ...
7 years, 10 months ago (2011-08-25 15:03:04 UTC) #3
pkx166h
passes make and reg tests
7 years, 10 months ago (2011-08-27 08:10:31 UTC) #4
Ian Hulin (gmail)
LGTM Patch applied and it fixes documents originally showing collisions between double-lined breves, bar-lines and ...
7 years, 10 months ago (2011-08-27 23:22:30 UTC) #5
Ian Hulin (gmail)
Janek, Bertrand posted some review comments here. I think it would be polite in the ...
7 years, 10 months ago (2011-08-30 10:29:42 UTC) #6
janek
Ian, On 2011/08/30 10:29:42, Ian Hulin (gmail) wrote: > Janek, > Bertrand posted some review ...
7 years, 9 months ago (2011-09-06 08:54:40 UTC) #7
Graham Percival
On Tue, Sep 06, 2011 at 08:54:40AM +0000, janek.lilypond@gmail.com wrote: > I have new patch ...
7 years, 9 months ago (2011-09-06 10:28:08 UTC) #8
Bertrand Bordage
On 2011/09/06 08:54:40, janek wrote: > I'm not sure what you mean. Are you saying ...
7 years, 9 months ago (2011-09-06 16:26:40 UTC) #9
Janek Warchol
On 2011/09/06 16:26:40, Bertrand Bordage wrote: > On 2011/09/06 08:54:40, janek wrote: > > I'm ...
7 years, 9 months ago (2011-09-06 17:15:52 UTC) #10
Keith
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode183 mf/feta-noteheads.mf:183: set_char_box (stemthick# * linecount + gap# * (linecount - ...
7 years, 1 month ago (2012-05-09 06:03:39 UTC) #11
janek
On Wed, May 9, 2012 at 8:03 AM, <k-ohara5a5a@oco.net> wrote: > > http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf > File ...
7 years, 1 month ago (2012-05-09 15:01:43 UTC) #12
janek
7 years, 1 month ago (2012-05-09 21:52:12 UTC) #13
On Wed, May 9, 2012 at 5:01 PM, Janek Warchoł <janek.lilypond@gmail.com> wrote:
> On Wed, May 9, 2012 at 8:03 AM,  <k-ohara5a5a@oco.net> wrote:
>>
>> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
>> File mf/feta-noteheads.mf (right):
>>
>> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode183
>> mf/feta-noteheads.mf:183: set_char_box (stemthick# * linecount + gap# *
>> (linecount - 1),
>> Jan, the breves seem to be the only note-heads that have an extent to
>> the left of the reference point.  Presumably this is to make them line
>> up properly with whole-notes in note-columns.
>> It complicates chord-collisions a bit, so take a look at the issue 1713
>> patch if you can.
>
> I'll try - hopefully when i come back home today evening.

I've compiled it and checked the output of a test file; i see the
problem.  Unfortunately i'm too tired to continue testing today :(

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b