Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(297)

Issue 4922042: Creates a Flag grob. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
mikesol, Reinhold, Neil Puttock, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Creates a Flag grob.

Patch Set 1 #

Total comments: 11

Patch Set 2 : Comments from Reinhold and Han-Wen. #

Patch Set 3 : Changes flag-style to style. #

Patch Set 4 : Makes necessary fixes in the docs. #

Total comments: 9

Patch Set 5 : Makes changes suggested by Neil. #

Patch Set 6 : Reproduces horizontal spacing from current master. #

Patch Set 7 : Rebase against current master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -249 lines) Patch
M Documentation/learning/tweaks.itely View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Documentation/notation/ancient.itely View 1 2 3 10 chunks +12 lines, -2 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Documentation/notation/keyboards.itely View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/new/displaying-complex-chords.ly View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/new/guitar-slides.ly View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/new/unfretted-headword.ly View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web/ly-examples/granados.ly View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/color.ly View 1 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/flags-default.ly View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
M input/regression/flags-in-scheme.ly View 3 chunks +14 lines, -12 lines 0 comments Download
M input/regression/flags-straight.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/flags-straight-stockhausen-boulez.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/graphviz.ly View 1 chunk +2 lines, -0 lines 0 comments Download
M input/regression/grid-lines.ly View 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/les-nereides.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/mozart-hrn3-defs.ily View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/quote-overrides.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/beam-quanting.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/dot-column.cc View 1 chunk +5 lines, -7 lines 0 comments Download
A lily/flag.cc View 1 2 3 4 5 1 chunk +175 lines, -0 lines 0 comments Download
M lily/include/stem.hh View 2 chunks +1 line, -3 lines 0 comments Download
M lily/rhythmic-column-engraver.cc View 1 2 3 4 5 6 chunks +13 lines, -0 lines 0 comments Download
M lily/stem.cc View 1 2 3 4 6 chunks +8 lines, -129 lines 0 comments Download
M lily/stem-engraver.cc View 1 2 3 4 5 chunks +31 lines, -2 lines 0 comments Download
M lily/tie-formatting-problem.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M ly/engraver-init.ly View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ly/grace-init.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M ly/gregorian.ly View 1 chunk +1 line, -0 lines 0 comments Download
M ly/property-init.ly View 1 2 4 chunks +8 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 2 chunks +1 line, -10 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 6 chunks +20 lines, -3 lines 0 comments Download
M scm/flag-styles.scm View 1 2 10 chunks +49 lines, -42 lines 0 comments Download
M scm/music-functions.scm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14
MikeSol
This should do the trick. The regtests don't really help as they show tons of ...
7 years, 10 months ago (2011-08-21 21:26:06 UTC) #1
hanwenn
quick remarks - Why are the flags called "maybe"flags in the engraver? - Currently, the ...
7 years, 10 months ago (2011-08-22 01:56:23 UTC) #2
MikeSol
On 2011/08/22 01:56:23, hanwenn wrote: > quick remarks > > - Why are the flags ...
7 years, 10 months ago (2011-08-22 06:16:47 UTC) #3
Reinhold
http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly File input/regression/color.ly (right): http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly#newcode24 input/regression/color.ly:24: \override Flag #'color = #blue Why don't you choose ...
7 years, 10 months ago (2011-08-22 10:06:36 UTC) #4
mikesol_ufl.edu
On Aug 22, 2011, at 12:06 PM, reinhold.kainhofer@gmail.com wrote: > > http://codereview.appspot.com/4922042/diff/1/input/regression/color.ly > File input/regression/color.ly ...
7 years, 10 months ago (2011-08-22 10:20:53 UTC) #5
hanwenn
On Mon, Aug 22, 2011 at 7:20 AM, Mike Solomon <mikesol@ufl.edu> wrote: > http://codereview.appspot.com/4922042/diff/1/scm/define-grob-properties.scm#newcode276 > ...
7 years, 10 months ago (2011-08-22 12:52:05 UTC) #6
MikeSol
On 2011/08/22 12:52:05, hanwenn wrote: > On Mon, Aug 22, 2011 at 7:20 AM, Mike ...
7 years, 10 months ago (2011-08-22 13:07:52 UTC) #7
Neil Puttock
http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc File lily/flag.cc (right): http://codereview.appspot.com/4922042/diff/17001/lily/flag.cc#newcode147 lily/flag.cc:147: "what style of flag glyph is typeset on a" ...
7 years, 10 months ago (2011-08-24 21:53:36 UTC) #8
mikesol_ufl.edu
On Aug 24, 2011, at 11:53 PM, n.puttock@gmail.com wrote: > Thanks for your suggestions Neil! ...
7 years, 10 months ago (2011-08-25 10:03:40 UTC) #9
mikesol_ufl.edu
On Aug 25, 2011, at 12:03 PM, Mike Solomon wrote: > On Aug 24, 2011, ...
7 years, 10 months ago (2011-08-25 10:51:44 UTC) #10
hanwenn
On Thu, Aug 25, 2011 at 7:03 AM, Mike Solomon <mikesol@ufl.edu> wrote: > I have ...
7 years, 10 months ago (2011-08-25 13:17:27 UTC) #11
mikesol_ufl.edu
On Aug 25, 2011, at 3:17 PM, Han-Wen Nienhuys wrote: > On Thu, Aug 25, ...
7 years, 10 months ago (2011-08-25 19:08:12 UTC) #12
mikesol_ufl.edu
On Aug 25, 2011, at 9:08 PM, Mike Solomon wrote: > On Aug 25, 2011, ...
7 years, 10 months ago (2011-08-25 20:43:04 UTC) #13
MikeSol
7 years, 10 months ago (2011-08-27 14:34:42 UTC) #14
Pushed as f0978ed121192fee9bdf2453a325d98693148acf.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b