Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1803)

Issue 4914042: code review 4914042: weekly.2011-08-17 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by adg
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

weekly.2011-08-17

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 5d8a3971fbf0 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r a561c0acceeb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2011-08-18 02:44:23 UTC) #1
r
http://codereview.appspot.com/4914042/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4914042/diff/1/doc/devel/weekly.html#newcode26 doc/devel/weekly.html:26: its import lines to "old/template" or "template", respectively. what ...
9 years, 6 months ago (2011-08-18 03:43:05 UTC) #2
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2011-08-18 03:52:41 UTC) #3
r
LGTM http://codereview.appspot.com/4914042/diff/2002/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4914042/diff/2002/doc/devel/weekly.html#newcode32 doc/devel/weekly.html:32: URLEscape) has been moved to the new url ...
9 years, 6 months ago (2011-08-18 04:02:28 UTC) #4
adg
9 years, 6 months ago (2011-08-18 04:27:20 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=6eb2b9dbe489 ***

weekly.2011-08-17

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4914042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b