Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 4907046: Fix typo in optimization script and make sure errors aren't swallowed by benchmarking script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Roger McFarlane
Modified:
6 years, 2 months ago
Reviewers:
chrisha, Siggi
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix typo in optimization script and make sure errors aren't swallowed by benchmarking script Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk400

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M syzygy/scripts/benchmark/benchmark.py View 1 chunk +1 line, -0 lines 1 comment Download
M syzygy/scripts/benchmark/optimize.py View 2 chunks +3 lines, -3 lines 3 comments Download

Messages

Total messages: 4
Roger McFarlane
PTAL http://codereview.appspot.com/4907046/diff/1/syzygy/scripts/benchmark/benchmark.py File syzygy/scripts/benchmark/benchmark.py (left): http://codereview.appspot.com/4907046/diff/1/syzygy/scripts/benchmark/benchmark.py#oldcode87 syzygy/scripts/benchmark/benchmark.py:87: logging.exception('Exception in Run.') arg ... swallowing exceptions! Fixed. ...
6 years, 2 months ago (2011-08-17 03:21:53 UTC) #1
Siggi
lgtm
6 years, 2 months ago (2011-08-17 13:34:30 UTC) #2
chrisha
lgtm!
6 years, 2 months ago (2011-08-17 13:36:41 UTC) #3
Roger McFarlane
6 years, 2 months ago (2011-08-17 13:44:20 UTC) #4
Committed, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted