Issue 4902050: AddressSanitizer/CLANG first patch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4902050: AddressSanitizer/CLANG first patch

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by kcc2

Modified:
5 years, 6 months ago

Reviewers:
nlewycky1, christianity.webb

CC:
christianity.webb

Base URL:
http://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 2 : added comment #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
M	include/clang/Driver/CC1Options.td	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/clang/Frontend/CodeGenOptions.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	lib/CodeGen/BackendUtil.cpp	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	lib/Frontend/CompilerInvocation.cpp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nlewycky1

LGTM http://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td File include/clang/Driver/CC1Options.td (right): http://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td#newcode114 include/clang/Driver/CC1Options.td:114: HelpText<"Enable AddressSanitizer instrumentation">; This is okay, but the ...

12 years, 8 months ago (2011-08-18 22:10:10 UTC) #1

christianity.webb

5 years, 6 months ago (2018-10-06 02:20:32 UTC) #2

this is all I do personally why is this question so Stupid; CORRECT YOUR OWN
FLAGS.
____________________Or does chromium have to do all the
work._____________________gmabp.

       Does anyone Really Rule their own Web?

https://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td
File include/clang/Driver/CC1Options.td (right):

https://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options...
include/clang/Driver/CC1Options.td:114: HelpText<"Enable AddressSanitizer
instrumentation">;
On 2011/08/18 22:10:11, nlewycky1 wrote:
> This is okay, but the help text usually explains what it does, such as "Add
> runtime checks that pointers are valid."

Acknowledged.

in order to edit it should read:  TextHelp<=EnabledAddress:Sanititizer
instrumentation">; 'instrumentation' itself means it can't do it on it's own.
and TextHelp etc. in that order bc it is a chromebook.

Expand All Messages | Collapse All Messages