Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2283)

Issue 4902050: AddressSanitizer/CLANG first patch

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by kcc2
Modified:
1 week, 3 days ago
CC:
christianity.webb
Base URL:
http://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M include/clang/Driver/CC1Options.td View 1 1 chunk +2 lines, -0 lines 0 comments Download
M include/clang/Frontend/CodeGenOptions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M lib/CodeGen/BackendUtil.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M lib/Frontend/CompilerInvocation.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
nlewycky1
LGTM http://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td File include/clang/Driver/CC1Options.td (right): http://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td#newcode114 include/clang/Driver/CC1Options.td:114: HelpText<"Enable AddressSanitizer instrumentation">; This is okay, but the ...
7 years, 2 months ago (2011-08-18 22:10:10 UTC) #1
christianity.webb
1 week, 3 days ago (2018-10-06 02:20:32 UTC) #2
this is all I do personally why is this question so Stupid; CORRECT YOUR OWN
FLAGS.
____________________Or does chromium have to do all the
work._____________________gmabp.


       Does anyone Really Rule their own Web?

https://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options.td
File include/clang/Driver/CC1Options.td (right):

https://codereview.appspot.com/4902050/diff/1/include/clang/Driver/CC1Options...
include/clang/Driver/CC1Options.td:114: HelpText<"Enable AddressSanitizer
instrumentation">;
On 2011/08/18 22:10:11, nlewycky1 wrote:
> This is okay, but the help text usually explains what it does, such as "Add
> runtime checks that pointers are valid."

Acknowledged.

in order to edit it should read:  TextHelp<=EnabledAddress:Sanititizer
instrumentation">; 'instrumentation' itself means it can't do it on it's own.
and TextHelp etc. in that order bc it is a chromebook.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b