Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 4902048: Bump build VERSION to 0.1.1.0. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Siggi
Modified:
6 years, 2 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Bump build VERSION to 0.1.1.0. Fix errors in version unittest and implementation. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk401

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M syzygy/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M syzygy/common/syzygy_version.cc View 1 1 chunk +2 lines, -2 lines 1 comment Download
M syzygy/common/syzygy_version_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Siggi
6 years, 2 months ago (2011-08-17 15:16:04 UTC) #1
Siggi
6 years, 2 months ago (2011-08-17 15:26:23 UTC) #2
chrisha
lgtm! http://codereview.appspot.com/4902048/diff/3001/syzygy/common/syzygy_version.cc File syzygy/common/syzygy_version.cc (right): http://codereview.appspot.com/4902048/diff/3001/syzygy/common/syzygy_version.cc#newcode35 syzygy/common/syzygy_version.cc:35: patch_(patch), Oops! ;)
6 years, 2 months ago (2011-08-17 15:27:53 UTC) #3
Roger McFarlane
6 years, 2 months ago (2011-08-17 15:31:38 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted