Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1826)

Issue 4898058: DOC: Revise CG 3.4 Commit Access (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by Colin Campbell
Modified:
7 years, 10 months ago
Reviewers:
janek, Graham Percival (old account), reinhold, Graham Percival, Reinhold, phileholmes
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

DOC: Revise CG 3.4 Commit Access

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M Documentation/contributor/source-code.itexi View 5 chunks +15 lines, -10 lines 3 comments Download

Messages

Total messages: 15
Graham Percival (old account)
LGTM, one suggestion. http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi#newcode1574 Documentation/contributor/source-code.itexi:1574: making commits. An alternate method would ...
7 years, 10 months ago (2011-08-18 02:45:05 UTC) #1
PhilEHolmes
LGTM too. My suggestion would be to add some instructions about actually pushing. It took ...
7 years, 10 months ago (2011-08-18 11:21:22 UTC) #2
Reinhold
On 2011/08/18 11:21:22, PhilEHolmes wrote: > LGTM too. My suggestion would be to add some ...
7 years, 10 months ago (2011-08-18 11:42:06 UTC) #3
Reinhold
http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi#newcode1425 Documentation/contributor/source-code.itexi:1425: Generate an SSH @q{rsa} key pair. Enter the following ...
7 years, 10 months ago (2011-08-18 11:42:13 UTC) #4
Graham Percival (old account)
On 2011/08/18 11:42:13, Reinhold wrote: > Documentation/contributor/source-code.itexi:1425: Generate an SSH @q{rsa} key > pair. Enter ...
7 years, 10 months ago (2011-08-19 00:29:22 UTC) #5
reinhold_kainhofer.com
Am Friday 19 August 2011, 02:29:22 schrieb percival.music.ca@gmail.com: > On 2011/08/18 11:42:13, Reinhold wrote: > ...
7 years, 10 months ago (2011-08-19 01:21:24 UTC) #6
Graham Percival
On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote: > Am Friday 19 ...
7 years, 10 months ago (2011-08-19 03:11:15 UTC) #7
Colin Campbell
On 2011/08/19 03:11:15, graham_percival-music.ca wrote: > On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold ...
7 years, 10 months ago (2011-08-19 03:45:31 UTC) #8
reinhold_kainhofer.com
Am Friday, 19. August 2011, 05:11:30 schrieben Sie: > On Fri, Aug 19, 2011 at ...
7 years, 10 months ago (2011-08-21 13:29:44 UTC) #9
janek
On 2011/08/18 11:42:06, Reinhold wrote: > On 2011/08/18 11:21:22, PhilEHolmes wrote: > > LGTM too. ...
7 years, 10 months ago (2011-08-21 18:51:16 UTC) #10
Colin Campbell
Regarding the addition of instructions on how to push, I'd like to do that in ...
7 years, 10 months ago (2011-08-21 23:41:20 UTC) #11
Graham Percival (old account)
Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. ...
7 years, 10 months ago (2011-08-22 07:49:41 UTC) #12
janek
2011/8/22 <percival.music.ca@gmail.com>: > Yes, definitely do the pushing stuff in a separate patch. But here's ...
7 years, 10 months ago (2011-08-22 08:23:48 UTC) #13
reinhold_kainhofer.com
Am Monday, 22. August 2011, 09:49:41 schrieben Sie: > Yes, definitely do the pushing stuff ...
7 years, 10 months ago (2011-08-22 08:52:28 UTC) #14
Colin Campbell
7 years, 10 months ago (2011-08-24 02:36:58 UTC) #15
Pushed as 5f81429c8f8263eef85b4f7881d243cb9722e971

Details of how to push will be in a seperate patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b