Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 4894053: Adds a site search to website and improves doc search (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by PhilEHolmes
Modified:
7 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

See Issue 1405 - this allows users to search the site as well as the docs, and improves the way that Google is used to search for docs. In the first instance this will mean that the English site gets a different search from translated sites. Once this is pushed, we will need to get translations for the "Search site" and "Search docs" phrases, and I will try to put the language phrase into the search box automatically, rather than having a lot of near identical search-box.ihtml files.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M Documentation/css/lilypond-website.css View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/search-box.ihtml View 1 chunk +22 lines, -9 lines 0 comments Download

Messages

Total messages: 9
PhilEHolmes
Updates website search. Please review.
7 years, 10 months ago (2011-08-18 16:59:07 UTC) #1
janek
Hi, i've downloaded the patch and compiled website (with 'make website'), but there is a ...
7 years, 10 months ago (2011-08-22 21:06:25 UTC) #2
Graham Percival
On Tue, Aug 23, 2011 at 03:32:40PM +0100, Phil Holmes wrote: > ----- Original Message ...
7 years, 10 months ago (2011-08-23 18:04:39 UTC) #3
email_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: "Janek Warchol" ...
7 years, 10 months ago (2011-08-23 20:15:20 UTC) #4
mail_philholmes.net
----- Original Message ----- From: "Phil Holmes" <email@philholmes.net> To: "Graham Percival" <graham@percival-music.ca> Cc: <reply@codereview.appspotmail.com>; <PhilEHolmes@googlemail.com>; ...
7 years, 10 months ago (2011-08-23 20:32:58 UTC) #5
Graham Percival
On Tue, Aug 23, 2011 at 09:32:50PM +0100, Phil Holmes wrote: > ----- Original Message ...
7 years, 10 months ago (2011-08-23 21:11:33 UTC) #6
Graham Percival (old account)
I have grave doubts about adding a second search box. 1) it makes the top ...
7 years, 10 months ago (2011-08-26 04:26:32 UTC) #7
mail_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com>; <janek.lilypond@gmail.com>; <graham@percival-music.ca>; <email@philholmes.net>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com> ...
7 years, 10 months ago (2011-08-26 08:15:12 UTC) #8
janek
7 years, 9 months ago (2011-09-06 20:40:26 UTC) #9
2011/8/26  <percival.music.ca@gmail.com>:
> I have grave doubts about adding a second search box.
> 1) it makes the top bar uncomfortably squashed in my default web browser
> window
> 2) it requires users to choose which type of search they want to do.
>
>
> #1 isn't about me forcing my desktop browser preferences on anybody, but
> rather I'm making the point that almost all other websites work well on
> my desktop.  I think we should be very cautious about making
> lilypond.org less accessible than the average websote.  (or perhaps I
> should specify "average geek website", since I'm sure that certain other
> genres of websites are much less accessible than places that I visit)
>
> Do we have any compelling evidence that we _need_ to separate these
> searches?  Didn't the previous system just search the website and stable
> docs; wasn't that sufficient?
>
> Also, IIRC there was a suggestion that we search for something like
>  site:lilypond.org/Documentation/v2.14/
> instead of adding +2.14.  Am I misremembering / would that work / etc?

What about searching all docs and website by default, but adding
something like "advanced search" where one can set what he wants to
search?
If not, i guess that searching stable docs + website would be ok (if
it's possible).

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b