Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 4888046: Fix 1816: Lilypond-Book: don't clear the auto-detected line-with, rather modify it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by Reinhold
Modified:
7 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lilypond-Book: don't clear the auto-detected line-with, rather modify it

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M python/book_snippets.py View 2 chunks +2 lines, -13 lines 2 comments Download

Messages

Total messages: 4
Graham Percival (old account)
Thanks so much for looking into this! http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py#oldcode424 python/book_snippets.py:424: if type ...
7 years, 10 months ago (2011-08-15 21:34:16 UTC) #1
Reinhold
http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py#oldcode424 python/book_snippets.py:424: if type == 'lilypond': On 2011/08/15 21:34:16, Graham Percival ...
7 years, 10 months ago (2011-08-15 21:50:51 UTC) #2
Graham Percival (old account)
LGTM
7 years, 10 months ago (2011-08-26 03:11:59 UTC) #3
Graham Percival (old account)
7 years, 10 months ago (2011-08-27 04:34:13 UTC) #4
countdown over, please please push so that we can get a better idea of how many
outstanding patches there are.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b