Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 4876051: Fixes issue 1628. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
Keith, mikesol, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes issue 1628.

Patch Set 1 #

Patch Set 2 : Adds logic from slur engraver to phrasing slur engraver. #

Patch Set 3 : Makes minimal changes to the engraver. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M input/regression/string-number-around-slur.ly View 1 2 1 chunk +1 line, -1 line 1 comment Download
M lily/new-fingering-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M lily/slur-engraver.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7
MikeSol
Cheers, MS
7 years, 10 months ago (2011-08-15 21:17:23 UTC) #1
Keith
So far, so good. Would you include the corresponding changes to phrasing-slur-engraver.cc (mostly a duplication ...
7 years, 10 months ago (2011-08-16 05:48:21 UTC) #2
hanwenn
Your patch is doing much more than address issue 1628. Can you do just the ...
7 years, 10 months ago (2011-08-16 11:06:28 UTC) #3
mikesol_ufl.edu
On Aug 16, 2011, at 1:06 PM, Han-Wen Nienhuys wrote: > Your patch is doing ...
7 years, 10 months ago (2011-08-16 11:12:47 UTC) #4
MikeSol
New patchset uploaded w/ minimal changes made (just the engravers).
7 years, 10 months ago (2011-08-17 10:21:53 UTC) #5
Keith
LGTM Now string numbers move around slurs as well. That didn't work in the old ...
7 years, 10 months ago (2011-08-17 20:42:37 UTC) #6
MikeSol
7 years, 10 months ago (2011-08-25 07:38:14 UTC) #7
Pushed as 29d1121d260318ed07f152c346a1a69e5dadb69d.

Keith: I ultimately decided not to change the textLengthOn in the regtest so
that the test can test if objects from the new-fingering-engraver have their
callbacks chained in the correct order.  Even if this leads to an aesthetically
inferior result, it shows the correct behavior in action.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b