Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 4841052: Progress on loose columns. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Progress on loose columns.

Patch Set 1 #

Patch Set 2 : Handles loose spacing better. #

Patch Set 3 : Better regtests, weeds out barlines. #

Total comments: 2

Patch Set 4 : Factors in padding earlier to avoid later computations. #

Patch Set 5 : Removes pretty print. #

Patch Set 6 : Some housekeeping to get rid of irrelevant comments. #

Total comments: 3

Patch Set 7 : Implements sliding scale between minimum and ideal spacing. #

Patch Set 8 : Rebase against current master. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -15 lines) Patch
A input/regression/spacing-loose-polyphony.ly View 1 2 3 4 5 6 1 chunk +17 lines, -0 lines 2 comments Download
M lily/spacing-determine-loose-columns.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M lily/spacing-loose-columns.cc View 1 2 3 4 5 6 3 chunks +43 lines, -11 lines 0 comments Download

Messages

Total messages: 11
MikeSol
Hey all, This patch makes some headway into the loose column problem, but I am ...
7 years, 10 months ago (2011-08-05 18:05:31 UTC) #1
MikeSol
Hey all, I'm pretty sure this is the best way to get around the loose ...
7 years, 10 months ago (2011-08-09 14:09:20 UTC) #2
Bertrand Bordage
What if we want a larger padding? In your regtest, the clef collides with the ...
7 years, 10 months ago (2011-08-09 14:30:49 UTC) #3
mike_apollinemike.com
On Aug 9, 2011, at 4:30 PM, bordage.bertrand@gmail.com wrote: > What if we want a ...
7 years, 10 months ago (2011-08-09 15:23:59 UTC) #4
Bertrand Bordage
LGTM (still one trailing whitespace in the regtest). Bertrand
7 years, 10 months ago (2011-08-09 19:18:17 UTC) #5
Neil Puttock
Hi Mike, The latest patch set breaks spacing-empty-bar.ly (we want left-loose-column-padding to be 0 in ...
7 years, 10 months ago (2011-08-09 22:45:59 UTC) #6
MikeSol
I think I've hit loose column nirvana with this most recent patch set. The only ...
7 years, 10 months ago (2011-08-10 09:16:54 UTC) #7
MikeSol
Hey all, This patch hasn't been on a countdown yet - could it get put ...
7 years, 9 months ago (2011-09-17 09:26:39 UTC) #8
pkx166h
passes make and reg tests I get some changes but they look ok - although ...
7 years, 9 months ago (2011-09-17 12:49:45 UTC) #9
mike_apollinemike.com
On Sep 17, 2011, at 2:49 PM, pkx166h@gmail.com wrote: > > > passes make and ...
7 years, 9 months ago (2011-09-17 12:58:09 UTC) #10
Neil Puttock
7 years, 9 months ago (2011-09-21 21:37:46 UTC) #11
LGTM.

http://codereview.appspot.com/4841052/diff/25001/input/regression/spacing-loo...
File input/regression/spacing-loose-polyphony.ly (right):

http://codereview.appspot.com/4841052/diff/25001/input/regression/spacing-loo...
input/regression/spacing-loose-polyphony.ly:1: \version "2.15.9"
2.15.13

http://codereview.appspot.com/4841052/diff/25001/input/regression/spacing-loo...
input/regression/spacing-loose-polyphony.ly:4: texidoc = "Loose columns are
spaced correctly in
describe which columns are loose in the example
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b