Issue 48190043: code review 48190043: undo CL 44150043 / 198bdc0984dd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 48190043: code review 48190043: undo CL 44150043 / 198bdc0984dd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by bradfitz

Modified:
10 years, 3 months ago

Reviewers:
rsc

CC:
golang-dev, golang-codereviews

Visibility:
Public.

Description

undo CL 44150043 / 198bdc0984dd See https://codereview.appspot.com/44150043/ ««« original CL description regexp: use sync.Pool For machines, not threads. Update Issue 4720 R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/44150043 »»»

Patch Set 1 #

Patch Set 2 : diff -r fe0a21b4dd1d https://go.googlecode.com/hg/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/pkg/regexp/regexp.go	View	1	3 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 3 months ago (2014-01-06 20:38:01 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=a2e863914acc *** undo CL 44150043 / 198bdc0984dd See https://codereview.appspot.com/44150043/ ««« original CL ...

10 years, 3 months ago (2014-01-06 20:38:06 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages