Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 4811043: request for Mid code review NSoC 2011 - LTE RRC extension

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Lalith Suresh
Modified:
10 years, 1 month ago
Reviewers:
mmezzavilla, pankaj
CC:
gpiro.poliba_gmail.com, f.capozzi_poliba.it
Visibility:
Public.

Patch Set 1 #

Total comments: 78
Unified diffs Side-by-side diffs Delta from patch set Stats (+1168 lines, -148 lines) Patch
M src/lte/examples/lte-multiple-flows.cc View 4 chunks +31 lines, -25 lines 0 comments Download
M src/lte/model/enb-net-device.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/lte/model/enb-net-device.cc View 4 chunks +4 lines, -3 lines 0 comments Download
A src/lte/model/enb-rrc-cp-entity.h View 1 chunk +97 lines, -0 lines 12 comments Download
A src/lte/model/enb-rrc-cp-entity.cc View 1 chunk +115 lines, -0 lines 4 comments Download
M src/lte/model/ideal-control-messages.h View 5 chunks +3 lines, -9 lines 2 comments Download
M src/lte/model/jakes-fading-realizations.h View 1 chunk +47 lines, -47 lines 0 comments Download
M src/lte/model/lte-mac-header.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/lte-spectrum-value-helper.cc View 2 chunks +28 lines, -28 lines 0 comments Download
M src/lte/model/rrc-entity.h View 2 chunks +5 lines, -2 lines 0 comments Download
A src/lte/model/rrc-ideal-control-messages.h View 1 chunk +400 lines, -0 lines 20 comments Download
A src/lte/model/rrc-ideal-control-messages.cc View 1 chunk +222 lines, -0 lines 26 comments Download
M src/lte/model/simple-packet-scheduler.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M src/lte/model/ue-net-device.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/lte/model/ue-net-device.cc View 3 chunks +5 lines, -4 lines 0 comments Download
A src/lte/model/ue-rrc-cp-entity.h View 1 chunk +90 lines, -0 lines 10 comments Download
A src/lte/model/ue-rrc-cp-entity.cc View 1 chunk +95 lines, -0 lines 4 comments Download
M src/lte/wscript View 3 chunks +8 lines, -8 lines 0 comments Download
M src/wimax/model/ipcs-classifier-record.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mmezzavilla
Dear all, my review is now available. Best regards, Marco http://codereview.appspot.com/4811043/diff/1/src/lte/model/enb-rrc-cp-entity.cc File src/lte/model/enb-rrc-cp-entity.cc (right): http://codereview.appspot.com/4811043/diff/1/src/lte/model/enb-rrc-cp-entity.cc#newcode58 ...
10 years, 2 months ago (2011-07-22 10:09:11 UTC) #1
pankaj
Dear all, I have updated the code as suggested by the reviewers . I have ...
10 years, 1 month ago (2011-08-01 18:31:24 UTC) #2
pankaj
10 years, 1 month ago (2011-08-01 18:37:13 UTC) #3
Dear all,

I have updated the code as suggested by the reviewers . I have updated
the comments here


http://codereview.appspot.com/4811043

I have initiated a new code review with the updated changes.

http://codereview.appspot.com/4830049/

Please feel free to give your inputs.



Thanks in advance


Regards,
Pankaj
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b