Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Delta Between Two Patch Sets: Documentation/notation/changing-defaults.itely

Issue 4810072: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (Closed)
Left Patch Set: Incorporates Han Wen's suggestions and adds a regtest. Created 12 years, 7 months ago
Right Patch Set: Incorporates Keith's comments. Created 12 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 @c -*- coding: utf-8; mode: texinfo; -*- 1 @c -*- coding: utf-8; mode: texinfo; -*-
2 2
3 @ignore 3 @ignore
4 Translation of GIT committish: FILL-IN-HEAD-COMMITTISH 4 Translation of GIT committish: FILL-IN-HEAD-COMMITTISH
5 5
6 When revising a translation, copy the HEAD committish of the 6 When revising a translation, copy the HEAD committish of the
7 version that you are working on. For details, see the Contributors' 7 version that you are working on. For details, see the Contributors'
8 Guide, node Updating translation committishes.. 8 Guide, node Updating translation committishes..
9 @end ignore 9 @end ignore
10 10
(...skipping 3604 matching lines...) Expand 10 before | Expand all | Expand 10 after
3615 3615
3616 @menu 3616 @menu
3617 * Modifying ties and slurs:: 3617 * Modifying ties and slurs::
3618 @end menu 3618 @end menu
3619 3619
3620 @node Modifying ties and slurs 3620 @node Modifying ties and slurs
3621 @unnumberedsubsubsec Modifying ties and slurs 3621 @unnumberedsubsubsec Modifying ties and slurs
3622 3622
3623 @cindex slurs, modifying 3623 @cindex slurs, modifying
3624 @cindex ties, modifying 3624 @cindex ties, modifying
3625 @cindex Bézier curves, control points 3625 @cindex Bézier curves
3626 @cindex control points, Bézier curves 3626 @cindex Bézier control points
3627 3627
3628 If the shape of the tie or slur which is calculated automatically is not 3628 Ties, slurs and phrasing slurs are drawn as third-order Bézier
3629 optimum, the shape may be modified manually by explicitly specifying the 3629 curves. If the shape of the tie or slur which is calculated
3630 control points required to define the curve needed. 3630 automatically is not optimum, the shape may be modified manually by
3631 3631 explicitly specifying the four control points required to define
3632 Ties, slurs and phrasing slurs are drawn as @q{third-order} Bézier 3632 a third-order Bézier curve.
3633 curves which are are defined by four control points. The first and 3633
3634 fourth control points are the start and end points of the curve 3634 Third-order or cubic Bézier curves are defined by four control
3635 respectively, and the two intermediate control points define the 3635 points. The first and fourth control points are precisely the
3636 overall shape. 3636 starting and ending points of the curve. The intermediate two
3637 3637 control points define the shape. Animations showing how the curve
3638 Animations showing how the curve is drawn can be found on the web, but 3638 is drawn can be found on the web, but the following description
3639 the following description may be helpful. The curve starts from the 3639 may be helpful. The curve starts from the first control point
3640 first control point moving towards the second. As the curve nears and 3640 heading directly towards the second, gradually bending over to
3641 passes through the second control point it begins to arc towards the 3641 head towards the third and continuing to bend over to head towards
3642 third. The curve continues on towards the the third control point, 3642 the fourth, arriving there travelling directly from the third
3643 again starting to arc as it nears and passes through the third so as to 3643 control point. The curve is entirely contained in the
3644 finish the curve smoothly at the fourth and final control point. The 3644 quadrilateral defined by the four control points.
3645 whole curve is contained in the quadrilateral defined by the four 3645
3646 control points. 3646 Here is an example of a case where the tie is not optimum, and
3647 3647 where @code{\tieDown} would not help.
3648 Here is an example of a case where the tie is not optimum (and where the
3649 @code{\tieDown} command would not help).
3650 3648
3651 @lilypond[verbatim,quote,relative=1] 3649 @lilypond[verbatim,quote,relative=1]
3652 << 3650 <<
3653 { e1~ e } 3651 { e1 ~ e }
3654 \\ 3652 \\
3655 { r4 <g c,> <g c,> <g c,> } 3653 { r4 <g c,> <g c,> <g c,> }
3656 >> 3654 >>
3657 @end lilypond 3655 @end lilypond
3658 3656
3659 One way of improving this tie is to manually modify its control 3657 One way of improving this tie is to manually modify its control
3660 points, as follows. 3658 points, as follows.
3661 3659
3662 The coordinates of the Bézier control points are specified in units 3660 The coordinates of the Bézier control points are specified in units
3663 of staff-spaces. The X@tie{}coordinate is relative to the reference 3661 of staff-spaces. The X@tie{}coordinate is relative to the reference
(...skipping 12 matching lines...) Expand all
3676 3674
3677 For the example above the following override gives a satisfactory 3675 For the example above the following override gives a satisfactory
3678 tie. Note the placement -- it has to be immediately before the note 3676 tie. Note the placement -- it has to be immediately before the note
3679 to which the start of the tie (or slur) is attached. 3677 to which the start of the tie (or slur) is attached.
3680 3678
3681 @lilypond[verbatim,quote,relative=1] 3679 @lilypond[verbatim,quote,relative=1]
3682 << 3680 <<
3683 { 3681 {
3684 \once \override Tie 3682 \once \override Tie
3685 #'control-points = #'((1 . -1) (3 . 0.6) (12.5 . 0.6) (14.5 . -1)) 3683 #'control-points = #'((1 . -1) (3 . 0.6) (12.5 . 0.6) (14.5 . -1))
3686 e1 ~ e 3684 e1 ~ e1
3687 } 3685 }
3688 \\ 3686 \\
3689 { r4 <g c,> <g c,> <g c,> } 3687 { r4 <g c,> <g c,> <g c,>4 }
3690 >> 3688 >>
3691 @end lilypond 3689 @end lilypond
3692 3690
3693 @knownissues 3691 @knownissues
3692
3694 It is not possible to modify shapes of ties or slurs by changing 3693 It is not possible to modify shapes of ties or slurs by changing
3695 the @code{control-points} property if there are multiple ties or slurs 3694 the @code{control-points} property if there are more than one at
3696 at the same musical moment -- the @code{\tweak} command will also not 3695 the same musical moment, not even by using the @code{\tweak}
3697 work in this case. However, the @code{tie-configuration} property of 3696 command. However, the @code{tie-configuration} property of
3698 @code{tie-column-interface} can be overridden to set start line and 3697 @code{TieColumn} can be overridden to set start line and direction
3699 direction of ties as required. 3698 of ties as required.
3700 3699
3701 @seealso 3700
3702 Internals Reference:
3703 @rinternals{tie-column-interface}.
3704 3701
3705 3702
3706 @node Using music functions 3703 @node Using music functions
3707 @section Using music functions 3704 @section Using music functions
3708 3705
3709 @c TODO -- add @seealso, etc. to these subsections 3706 @c TODO -- add @seealso, etc. to these subsections
3710 3707
3711 Where tweaks need to be reused with different music expressions, 3708 Where tweaks need to be reused with different music expressions,
3712 it is often convenient to make the tweak part of a @emph{music 3709 it is often convenient to make the tweak part of a @emph{music
3713 function}. In this section, we discuss only @emph{substitution} 3710 function}. In this section, we discuss only @emph{substitution}
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
3856 3853
3857 \relative c'' { 3854 \relative c'' {
3858 \tempo \markup { "Low tempo" } 3855 \tempo \markup { "Low tempo" }
3859 c4 d e f g1 3856 c4 d e f g1
3860 \tempoPadded #4.0 #"High tempo" 3857 \tempoPadded #4.0 #"High tempo"
3861 g4 f e d c1 3858 g4 f e d c1
3862 } 3859 }
3863 @end lilypond 3860 @end lilypond
3864 3861
3865 @c TODO: add appropriate @@ref's here. 3862 @c TODO: add appropriate @@ref's here.
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b