Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1552)

Delta Between Two Patch Sets: Documentation/contributor/programming-work.itexi

Issue 4810072: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (Closed)
Left Patch Set: Incorporates Han Wen's suggestions and adds a regtest. Created 12 years, 8 months ago
Right Patch Set: Incorporates Keith's comments. Created 12 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 @c -*- coding: utf-8; mode: texinfo; -*- 1 @c -*- coding: utf-8; mode: texinfo; -*-
2 @node Programming work 2 @node Programming work
3 @chapter Programming work 3 @chapter Programming work
4 4
5 @menu 5 @menu
6 * Overview of LilyPond architecture:: 6 * Overview of LilyPond architecture::
7 * LilyPond programming languages:: 7 * LilyPond programming languages::
8 * Programming without compiling:: 8 * Programming without compiling::
9 * Finding functions:: 9 * Finding functions::
10 * Code style:: 10 * Code style::
(...skipping 1661 matching lines...) Expand 10 before | Expand all | Expand 10 after
1672 line is, but I also need to draw a clef, key signature, and possibly 1672 line is, but I also need to draw a clef, key signature, and possibly
1673 other fundamental things -- but at that stage in the rendering 1673 other fundamental things -- but at that stage in the rendering
1674 pipeline, is it not too late?? 1674 pipeline, is it not too late??
1675 1675
1676 Joe Neeman answered: 1676 Joe Neeman answered:
1677 1677
1678 We create lots of extra grobs (eg. a BarNumber at every bar line) but 1678 We create lots of extra grobs (eg. a BarNumber at every bar line) but
1679 most of them are not drawn. See the break-visibility property in 1679 most of them are not drawn. See the break-visibility property in
1680 item-interface. 1680 item-interface.
1681 1681
1682 Here is another e-mail exchange. Janek WarchoĊ‚ asked for a starting point
1683 to fixing 1301 (change clef colliding with notes). Neil Puttock replied:
1684
1685 The clef is on a loose column (it floats before the head), so the
1686 first place I'd look would be lily/spacing-loose-columns.cc (and
1687 possibly lily/spacing-determine-loose-columns.cc).
1688 I'd guess the problem is the way loose columns are spaced between
1689 other columns: in this snippet, the columns for the quaver and tuplet
1690 minim are so close together that the clef's column gets dumped on top
1691 of the quaver (since it's loose, it doesn't influence the spacing).
1692 1682
1693 @node Info from Han-Wen email 1683 @node Info from Han-Wen email
1694 @subsection Info from Han-Wen email 1684 @subsection Info from Han-Wen email
1695 1685
1696 In 2004, Douglas Linhardt decided to try starting a document that would 1686 In 2004, Douglas Linhardt decided to try starting a document that would
1697 explain LilyPond architecture and design principles. The material below 1687 explain LilyPond architecture and design principles. The material below
1698 is extracted from that email, which can be found at 1688 is extracted from that email, which can be found at
1699 @uref{http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/2992}. 1689 @uref{http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/2992}.
1700 The headings reflect questions from Doug or comments from Han-Wen; 1690 The headings reflect questions from Doug or comments from Han-Wen;
1701 the body text are Han-Wen's answers. 1691 the body text are Han-Wen's answers.
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
2049 #(display conditionalMark) 2039 #(display conditionalMark)
2050 @end example 2040 @end example
2051 2041
2052 noindent 2042 noindent
2053 inside the @file{.ly} file. 2043 inside the @file{.ly} file.
2054 2044
2055 The breakpoint failing may have to do with the call sequence. See 2045 The breakpoint failing may have to do with the call sequence. See
2056 @file{parser.yy}, run_music_function(). The function is called directly from 2046 @file{parser.yy}, run_music_function(). The function is called directly from
2057 C++, without going through the GUILE evaluator, so I think that is why 2047 C++, without going through the GUILE evaluator, so I think that is why
2058 there is no debugger trap. 2048 there is no debugger trap.
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b