Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(260)

Issue 4808082: Prevents nested tuplets from colliding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 8 months ago
Reviewers:
pkx166h, trevorbaca, Trevor Daniels, mike, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Prevents nested tuplets from colliding.

Patch Set 1 : Modifies regtest. #

Total comments: 3

Patch Set 2 : Fixes line breaking problems. #

Patch Set 3 : Addresses Neil's comments. #

Patch Set 4 : Rebase against current master. #

Total comments: 11

Patch Set 5 : Broken but fixable. #

Patch Set 6 : Better implementation that uses real tuplet numbers. #

Patch Set 7 : Spruces up regtests. #

Patch Set 8 : Rebased against current master. #

Patch Set 9 : Rebase against current master #

Patch Set 10 : Slimmer version #

Patch Set 11 : Nixes unused function. #

Patch Set 12 : Deletes some vestigial properties #

Patch Set 13 : Deletes tuplet-nest-force-shift-over-numbers.ly #

Total comments: 1

Patch Set 14 : Rebase against current master. #

Patch Set 15 : Rebase against current master. #

Patch Set 16 : issue 1855 rebased against current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -66 lines) Patch
M input/regression/tuplet-nest.ly View 1 2 3 4 6 1 chunk +14 lines, -2 lines 0 comments Download
A input/regression/tuplet-nest-broken.ly View 1 2 3 4 5 6 1 chunk +53 lines, -0 lines 0 comments Download
M lily/include/tuplet-bracket.hh View 1 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M lily/tuplet-bracket.cc View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +21 lines, -48 lines 0 comments Download
M lily/tuplet-number.cc View 1 2 chunks +29 lines, -13 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17
MikeSol
This fixes Issue 509 and passes regtests. Cheers, MS
7 years, 10 months ago (2011-08-08 19:21:08 UTC) #1
pkx166h
Passes make and reg test diff looks ok see http://code.google.com/p/lilypond/issues/detail?id=509#c4 for attached png
7 years, 10 months ago (2011-08-08 21:14:54 UTC) #2
Neil Puttock
Hi Mike, Have you tested this with broken tuplets? I've tried adding breaks at random ...
7 years, 10 months ago (2011-08-11 21:40:36 UTC) #3
trevorbaca_gmail.com
On Mon, Aug 8, 2011 at 3:21 PM, <mtsolo@gmail.com> wrote: > Reviewers: , > > ...
7 years, 10 months ago (2011-08-12 19:27:20 UTC) #4
mike_apollinemike.com
On Aug 11, 2011, at 11:40 PM, n.puttock@gmail.com wrote: > Hi Mike, > > Have ...
7 years, 10 months ago (2011-08-14 16:24:34 UTC) #5
MikeSol
> I haven't gotten around to making the other changes you pointed out yet, but ...
7 years, 10 months ago (2011-08-17 09:47:28 UTC) #6
Neil Puttock
http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-broken.ly File input/regression/tuplet-nest-broken.ly (right): http://codereview.appspot.com/4808082/diff/13002/input/regression/tuplet-nest-broken.ly#newcode5 input/regression/tuplet-nest-broken.ly:5: texidoc = "Broken nested tuplets avoid each other correctly. ...
7 years, 10 months ago (2011-08-19 21:58:56 UTC) #7
mike_apollinemike.com
On Aug 19, 2011, at 11:58 PM, n.puttock@gmail.com wrote: > > > http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode283 > lily/tuplet-bracket.cc:283: ...
7 years, 10 months ago (2011-08-20 08:30:07 UTC) #8
mike_apollinemike.com
On Aug 20, 2011, at 10:30 AM, mike@apollinemike.com wrote: > >> http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode669 >> lily/tuplet-bracket.cc:669: // ...
7 years, 10 months ago (2011-08-21 15:09:11 UTC) #9
MikeSol
That didn't take too long - I scrapped the previous try and went at it ...
7 years, 10 months ago (2011-08-21 16:06:34 UTC) #10
MikeSol
Hey all, Sorry to not have pushed this yet, but I recently rebased this against ...
7 years, 10 months ago (2011-08-29 11:14:52 UTC) #11
pkx166h
Mike, passes make but during reg test check i get --snip-- Failed files: (6c/lily-5110fb03.ly) fatal ...
7 years, 10 months ago (2011-08-30 21:57:44 UTC) #12
MikeSol
On 2011/08/30 21:57:44, J_lowe wrote: > Mike, passes make but during reg test check i ...
7 years, 9 months ago (2011-09-01 13:15:44 UTC) #13
pkx166h
passes make, some trivial reg test differences but one is very different and I have ...
7 years, 9 months ago (2011-09-02 23:00:10 UTC) #14
Trevor Daniels
Mike says this is not yet ready for pushing in comment #11. We should not ...
7 years, 9 months ago (2011-09-06 07:41:58 UTC) #15
mike_apollinemike.com
On Sep 6, 2011, at 9:41 AM, tdanielsmusic@googlemail.com wrote: > Mike says this is not ...
7 years, 9 months ago (2011-09-17 10:20:20 UTC) #16
pkx166h
7 years, 9 months ago (2011-09-24 19:21:32 UTC) #17
Passes make and reg tests show as before see:

http://code.google.com/p/lilypond/issues/detail?id=1855#c9

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b