Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 4808074: Adds a glyph for tied lyrics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Bertrand Bordage
Modified:
7 years, 11 months ago
Reviewers:
wl, Neil Puttock, reinhold, lemzwerg, mail, Janek Warchol, pkx166h, pacovila, Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds a glyph for tied lyrics.

Patch Set 1 #

Patch Set 2 : Removed dummy variable and updated feta font table. #

Total comments: 1

Patch Set 3 : Applies Werner and James changes; fixes make doc. #

Total comments: 1

Patch Set 4 : Separate binding for half-space. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -46 lines) Patch
M Documentation/de/notation/vocal.itely View 1 chunk +4 lines, -8 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 1 chunk +4 lines, -9 lines 0 comments Download
M Documentation/fr/notation/notation-appendices.itely View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 1 chunk +4 lines, -10 lines 0 comments Download
M Documentation/included/font-table.ly View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Documentation/notation/notation-appendices.itely View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
M Documentation/po/fr.po View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mf/feta-generic.mf View 1 chunk +1 line, -0 lines 0 comments Download
M mf/feta-test-generic.mf View 1 chunk +1 line, -0 lines 0 comments Download
A mf/feta-ties.mf View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 26
Bertrand Bordage
Better handling of lyric ties: * The space between two tied words is no more ...
7 years, 11 months ago (2011-08-06 22:59:38 UTC) #1
lemzwerg
Please use tabs in MF files. Besides that, everythings looks fine.
7 years, 11 months ago (2011-08-07 05:49:20 UTC) #2
pkx166h
a 'while you're there' nitpick. http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely#newcode612 Documentation/notation/vocal.itely:612: code the tilde symbol ...
7 years, 11 months ago (2011-08-07 09:11:06 UTC) #3
Janek Warchol
I've created tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1807 Could you upload some pngs showing before/after output? It would ...
7 years, 11 months ago (2011-08-07 12:48:56 UTC) #4
Bertrand Bordage
Changes done. Passes make, regtest comparison and make doc. Bertrand
7 years, 11 months ago (2011-08-08 14:30:36 UTC) #5
pkx166h
Passes make and reg tests
7 years, 11 months ago (2011-08-08 21:05:45 UTC) #6
Janek Warchol
I'd make the tie slightly shorter. I find it awkward that two adjacent ties collide ...
7 years, 11 months ago (2011-08-08 23:23:29 UTC) #7
Bertrand Bordage
So do I, but a shorter tie would collide with commas. The best solution is ...
7 years, 11 months ago (2011-08-09 08:59:03 UTC) #8
pacovila
2011/8/9 <lemniskata.bernoullego@gmail.com>: > I'd make the tie slightly shorter. I find it awkward that two ...
7 years, 11 months ago (2011-08-10 15:35:27 UTC) #9
Bertrand Bordage
> Secondly, it does not follow the policy for syllable separator, which > is '[space]--[space]', ...
7 years, 11 months ago (2011-08-10 17:54:52 UTC) #10
reinhold_kainhofer.com
Am Mittwoch, 10. August 2011, 19:54:52 schrieb bordage.bertrand@gmail.com: > > Finally, 2nd and 3rd stanzas ...
7 years, 11 months ago (2011-08-10 21:00:33 UTC) #11
wl_gnu.org
> I can't find it now, but I definitely remember having seen three > syllables ...
7 years, 11 months ago (2011-08-10 21:22:10 UTC) #12
wl_gnu.org
> An example is the second aria of Susanna in Mozart's `Le Nozze di > ...
7 years, 11 months ago (2011-08-10 21:27:04 UTC) #13
pacovila
2011/8/10 Werner LEMBERG <wl@gnu.org>: >> I can't find it now, but I definitely remember having ...
7 years, 11 months ago (2011-08-10 22:11:07 UTC) #14
pacovila
2011/8/10 Werner LEMBERG <wl@gnu.org>: >> I can't find it now, but I definitely remember having ...
7 years, 11 months ago (2011-08-10 22:12:47 UTC) #15
pacovila
2011/8/10 Werner LEMBERG <wl@gnu.org>: >> An example is the second aria of Susanna in Mozart's ...
7 years, 11 months ago (2011-08-10 22:24:45 UTC) #16
wl_gnu.org
>> An example is the second aria of Susanna in Mozart's `Le Nozze di >> ...
7 years, 11 months ago (2011-08-11 05:35:14 UTC) #17
pacovila
2011/8/11 Werner LEMBERG <wl@gnu.org>: > >>> An example is the second aria of Susanna in ...
7 years, 11 months ago (2011-08-11 11:16:54 UTC) #18
Jean-Charles
Le 11/08/2011 13:16, Francisco Vila disait : > 2011/8/11 Werner LEMBERG<wl@gnu.org>: >> >>>> An example ...
7 years, 11 months ago (2011-08-11 11:37:46 UTC) #19
Bertrand Bordage
I forgot these cases (o~è~in; a~è~in; o~è~an...). They are often elided ("quest'in" instead of "questa~è~in") ...
7 years, 11 months ago (2011-08-11 11:50:46 UTC) #20
wl_gnu.org
>> No lyric ties either... > > So your view is that lyric ties are ...
7 years, 11 months ago (2011-08-12 05:22:52 UTC) #21
mail_philholmes.net
----- Original Message ----- From: "Werner LEMBERG" <wl@gnu.org> To: <paconet.org@gmail.com> Cc: <reply@codereview.appspotmail.com>; <lemzwerg@googlemail.com>; <lemniskata.bernoullego@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 11 months ago (2011-08-12 09:44:22 UTC) #22
Bertrand Bordage
Here's how a better solution should work: * create a smaller tie in addition to ...
7 years, 11 months ago (2011-08-13 10:12:50 UTC) #23
Neil Puttock
LGTM. http://codereview.appspot.com/4808074/diff/7001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4808074/diff/7001/scm/define-markup-commands.scm#newcode943 scm/define-markup-commands.scm:943: (tie-str (markup #:hspace (/ word-space 2) use separate ...
7 years, 11 months ago (2011-08-13 15:51:33 UTC) #24
Bertrand Bordage
> use separate binding for (/ word-space 2) Done.
7 years, 11 months ago (2011-08-14 08:08:48 UTC) #25
Bertrand Bordage
7 years, 11 months ago (2011-08-14 10:30:42 UTC) #26
Pushed as 8d148ea05fa4b34f8cc3407e112363d715b27ad8

Bertrand
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b