Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 4801083: Fixes issue 40. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
pkx166h, mike, carl.d.sorensen, Neil Puttock, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes issue 40.

Patch Set 1 #

Patch Set 2 : Adds regtest. #

Patch Set 3 : Implements minimum distance threshold. #

Total comments: 3

Patch Set 4 : Uses accidental-grob to harvest the accidental. #

Patch Set 5 : Rebased against master. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
A input/regression/glissando-accidental.ly View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M lily/line-spanner.cc View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M scm/define-grobs.scm View 3 1 chunk +5 lines, -4 lines 1 comment Download

Messages

Total messages: 14
MikeSol
Here's a fix for Issue 40. Cheers, MS
7 years, 10 months ago (2011-08-06 20:17:59 UTC) #1
pkx166h
Pass make and reg tests
7 years, 10 months ago (2011-08-06 20:51:01 UTC) #2
Carl
Can we have a regtest, please?
7 years, 10 months ago (2011-08-08 15:19:06 UTC) #3
MikeSol
On 2011/08/08 15:19:06, Carl wrote: > Can we have a regtest, please? Regtest added. Cheers, ...
7 years, 10 months ago (2011-08-08 18:52:58 UTC) #4
Carl
LGTM. Thanks, Carl
7 years, 10 months ago (2011-08-08 20:39:21 UTC) #5
hanwenn
LGTM note that image of the issue will also require a minimum distance setting, otherwise, ...
7 years, 10 months ago (2011-08-09 05:08:56 UTC) #6
MikeSol
On 2011/08/09 05:08:56, hanwenn wrote: > LGTM > > note that image of the issue ...
7 years, 10 months ago (2011-08-09 06:41:24 UTC) #7
Neil Puttock
On 9 August 2011 07:41, <mtsolo@gmail.com> wrote: > On 2011/08/09 05:08:56, hanwenn wrote: >> >> ...
7 years, 10 months ago (2011-08-09 17:11:21 UTC) #8
Neil Puttock
http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly File input/regression/glissando-accidental.ly (right): http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly#newcode8 input/regression/glissando-accidental.ly:8: a1 \glissando cis a1\glissando http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc File lily/line-spanner.cc (right): http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc#newcode113 ...
7 years, 10 months ago (2011-08-09 17:15:23 UTC) #9
mike_apollinemike.com
On Aug 9, 2011, at 7:15 PM, n.puttock@gmail.com wrote: > http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc#newcode113 > lily/line-spanner.cc:113: Grob *acc ...
7 years, 10 months ago (2011-08-09 18:23:42 UTC) #10
Neil Puttock
On 2011/08/09 18:23:42, mike_apollinemike.com wrote: > Good call - I've uploaded a new patch that ...
7 years, 10 months ago (2011-08-09 20:04:36 UTC) #11
mike_apollinemike.com
On Aug 9, 2011, at 10:04 PM, n.puttock@gmail.com wrote: > On 2011/08/09 18:23:42, mike_apollinemike.com wrote: ...
7 years, 10 months ago (2011-08-09 20:50:57 UTC) #12
Neil Puttock
LGTM. http://codereview.appspot.com/4801083/diff/14002/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4801083/diff/14002/scm/define-grobs.scm#newcode933 scm/define-grobs.scm:933: (end-on-accidental . #t) trailing whitespace
7 years, 10 months ago (2011-08-09 22:08:37 UTC) #13
MikeSol
7 years, 10 months ago (2011-08-22 06:39:39 UTC) #14
Pushed as b3c0b773bde05b3971f087ed6c5f4fb40a1b20b1.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b