Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 4801057: Add testing for _penter/_pexit. Fix an errant flag constant. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Siggi
Modified:
6 years, 2 months ago
Reviewers:
Roger McFarlane
CC:
sawbuck-changes_googlegroups.com
Base URL:
https://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add testing for _penter/_pexit. Fix an errant flag constant. R=rogerm@chromium.org BUG=None TEST=None Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk386

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -73 lines) Patch
M syzygy/call_trace/call_trace_defs.h View 1 chunk +1 line, -1 line 0 comments Download
M syzygy/call_trace/call_trace_dll_unittest.cc View 17 chunks +206 lines, -72 lines 1 comment Download

Messages

Total messages: 3
Siggi
6 years, 2 months ago (2011-07-26 12:29:48 UTC) #1
Roger McFarlane
lgtm http://codereview.appspot.com/4801057/diff/1/syzygy/call_trace/call_trace_dll_unittest.cc File syzygy/call_trace/call_trace_dll_unittest.cc (right): http://codereview.appspot.com/4801057/diff/1/syzygy/call_trace/call_trace_dll_unittest.cc#newcode545 syzygy/call_trace/call_trace_dll_unittest.cc:545: void __declspec(naked) TailRecursiveFunction(int depth) { Sweet!
6 years, 2 months ago (2011-07-26 13:29:24 UTC) #2
Siggi
6 years, 2 months ago (2011-07-26 14:57:25 UTC) #3
Thanks, committed.

On Tue, Jul 26, 2011 at 1:29 PM, <rogerm@chromium.org> wrote:

> lgtm
>
>
> http://codereview.appspot.com/**4801057/diff/1/syzygy/call_**
>
trace/call_trace_dll_unittest.**cc<http://codereview.appspot.com/4801057/diff/1/syzygy/call_trace/call_trace_dll_unittest.cc>
> File syzygy/call_trace/call_trace_**dll_unittest.cc (right):
>
> http://codereview.appspot.com/**4801057/diff/1/syzygy/call_**
>
trace/call_trace_dll_unittest.**cc#newcode545<http://codereview.appspot.com/4801057/diff/1/syzygy/call_trace/call_trace_dll_unittest.cc#newcode545>
> syzygy/call_trace/call_trace_**dll_unittest.cc:545: void __declspec(naked)
> TailRecursiveFunction(int depth) {
> Sweet!
>
>
>
http://codereview.appspot.com/**4801057/<http://codereview.appspot.com/4801057/>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted