Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 4794046: code review 4794046: ld: fix freebsd build reverting .interp move (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by niemeyer
Modified:
10 years, 4 months ago
Reviewers:
gustavo
CC:
golang-dev, r
Visibility:
Public.

Description

ld: fix freebsd build reverting .interp move

Patch Set 1 #

Patch Set 2 : code review 4794046: ld: fix freebsd build reverting .interp move #

Patch Set 3 : diff -r e325563c6a33 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1bf4e5073561 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8f4c6113ed2d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M src/cmd/5l/asm.c View 1 2 3 chunks +4 lines, -10 lines 0 comments Download
M src/cmd/6l/asm.c View 1 2 3 chunks +2 lines, -18 lines 0 comments Download
M src/cmd/8l/asm.c View 1 2 3 chunks +12 lines, -18 lines 0 comments Download
M src/cmd/ld/data.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/elf.c View 1 2 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6
r
LGTM
10 years, 4 months ago (2011-07-21 06:15:21 UTC) #1
niemeyer
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2011-07-21 06:47:09 UTC) #2
r
still LGTM
10 years, 4 months ago (2011-07-21 06:47:55 UTC) #3
niemeyer
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2011-07-21 06:48:54 UTC) #4
niemeyer
*** Submitted as http://code.google.com/p/go/source/detail?r=a4c2e46af9b2 *** ld: fix freebsd build reverting .interp move R=golang-dev, r CC=golang-dev ...
10 years, 4 months ago (2011-07-21 06:49:00 UTC) #5
gustavo_niemeyer.net
10 years, 4 months ago (2011-07-21 06:50:47 UTC) #6
> still LGTM

Sorry, was holding on the arm test result.  It looks good.

-- 
Gustavo Niemeyer
http://niemeyer.net
http://niemeyer.net/plus
http://niemeyer.net/twitter
http://niemeyer.net/blog

-- I never filed a patent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b