Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(296)

Issue 4714043: Add hihat halfopen glyph to font (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Carl
Modified:
7 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add hihat halfopen glyph to font

Patch Set 1 #

Patch Set 2 : Remove unnecessary epsilon from glyph #

Patch Set 3 : Change length of vertical line and glyph name #

Total comments: 2

Patch Set 4 : Fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M mf/feta-scripts.mf View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Carl
Here is the patch for the new hihat halfopen glyph as requested in Issue 1688. ...
7 years, 11 months ago (2011-07-14 01:43:56 UTC) #1
Janek Warchol
The slash looks too long to me, especially when compared to halfopen (unstopped). I'd change ...
7 years, 11 months ago (2011-07-14 19:50:37 UTC) #2
Carl
On 2011/07/14 19:50:37, Janek Warchol wrote: > The slash looks too long to me, especially ...
7 years, 11 months ago (2011-07-14 20:07:53 UTC) #3
Janek Warchol
2011/7/14 <Carl.D.Sorensen@gmail.com>: > On 2011/07/14 19:50:37, Janek Warchol wrote: >> >> The slash looks too ...
7 years, 11 months ago (2011-07-14 20:23:46 UTC) #4
pkx166h
Make and reg tests ok.
7 years, 11 months ago (2011-07-14 20:35:21 UTC) #5
Neil Puttock
Hi Carl, I can't comment on the code itself, but the name of the new ...
7 years, 11 months ago (2011-07-14 20:37:03 UTC) #6
Carl
I've got a new patch set up. I changed the name to halfopenvertical. I think ...
7 years, 10 months ago (2011-08-17 04:44:09 UTC) #7
lemzwerg
LGTM. http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf#newcode633 mf/feta-scripts.mf:633: height# / 2, height# / 2); Vertical align ...
7 years, 10 months ago (2011-08-17 05:25:36 UTC) #8
Carl
Thanks Werner. Fixed. http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf#newcode633 mf/feta-scripts.mf:633: height# / 2, height# / 2); ...
7 years, 10 months ago (2011-08-17 05:35:34 UTC) #9
janek
7 years, 10 months ago (2011-08-22 20:10:24 UTC) #10
LGTM!
(and sorry for delay)
thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b