code review 4678046: json: encode \n in strings as "\n", not "\u000A"

json: encode \r and \n in strings as e.g. "\n", not "\u000A"

This is allowed by the JSON spec and is shorter/easier to read.

[Evan Martin, 2011-07-09 19:54:39]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-07-09 20:04:29]

http://codereview.appspot.com/4678046/diff/5001/src/pkg/json/encode.go
File src/pkg/json/encode.go (right):

http://codereview.appspot.com/4678046/diff/5001/src/pkg/json/encode.go#newcod...
src/pkg/json/encode.go:350: } else if b == '\n' {
Just \n?

If we're doing \n, should probably also do \r and \t at least.  I'm not sure \b
and \f would add clarity over the \uxxxx form.

Let's ask Russ his opinion on Monday.

[Evan Martin, 2011-07-09 20:43:06]

I added \r for symmetry, and I'll wait for more feedback.

[rsc, 2011-07-11 06:35:59]

\r and \n is good.
let's leave \b and \f out.
no one cares about \f
and more people know \b as
word boundary than as backspace.

[bradfitz, 2011-07-11 14:31:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=81e9259d59df ***

json: encode \r and \n in strings as e.g. "\n", not "\u000A"

This is allowed by the JSON spec and is shorter/easier to read.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4678046

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[bradfitz, 2011-07-11 14:31:38]

LGTM

On Sat, Jul 9, 2011 at 1:43 PM, <evan.martin@gmail.com> wrote:

> I added \r for symmetry, and I'll wait for more feedback.
>
>
>
http://codereview.appspot.com/**4678046/<http://codereview.appspot.com/4678046/>
>