Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1217)

Issue 4664076: Move \RemoveEmptyStaves to new file for context modifications (issue #1760) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Neil Puttock
Modified:
7 years ago
Reviewers:
Janek Warchol, Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move \RemoveEmptyStaves to new file for context modifications. This allows \RemoveEmptyStaves to be invoked outside \layout blocks, i.e., directly following a context instantiation: \new Staff \RemoveEmptyStaves { ... } or \new Staff \with { \RemoveEmptyStaves } { ... } * ly/context-mods-init.ly: new file for context modification identifiers * ly/declarations-init.ly: include context-mods-init.ly; placed before engraver-init.ly to ensure \RemoveEmptyStaves is accessible for deprecated \RemoveEmptyStaffContext and analogues * ly/engraver-init.ly: remove \RemoveEmptyStaves declaration

Patch Set 1 #

Patch Set 2 : Add regression test. #

Patch Set 3 : Update regtest version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -31 lines) Patch
A input/regression/remove-empty-context-mod.ly View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A ly/context-mods-init.ly View 1 chunk +29 lines, -0 lines 0 comments Download
M ly/declarations-init.ly View 1 chunk +14 lines, -16 lines 0 comments Download
M ly/engraver-init.ly View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5
Neil Puttock
Here's a patch which implements my proposal for a separate context modifications init file (http://lists.gnu.org/archive/html/lilypond-devel/2010-07/msg00359.html).
7 years ago (2011-07-12 22:28:51 UTC) #1
Janek Warchol
The change looks pretty straightforward, but i don't understand why simply moving RemoveEmptyStaff definition changes ...
7 years ago (2011-07-13 07:33:39 UTC) #2
Reinhold
LGTM. On 2011/07/13 07:33:39, Janek Warchol wrote: > The change looks pretty straightforward, but i ...
7 years ago (2011-07-13 07:49:31 UTC) #3
Janek Warchol
2011/7/13 <reinhold.kainhofer@gmail.com>: > Because ly/declarations-init.ly contains: > > \layout { > \include "engraver-init.ly" > } ...
7 years ago (2011-07-13 10:45:35 UTC) #4
Neil Puttock
7 years ago (2011-07-17 22:04:38 UTC) #5
Pushed: cf2da187b5b99e963346e5944311bb77e2e52ff1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b