Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 4662082: Tweak setup script so that the tools work when extracted by setup tools. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Siggi
Modified:
6 years, 3 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Tweak setup script so that the tools work when extracted by setup tools. Fix build configuration. Increase logging verbosity to include all spawned command lines. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk380

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M syzygy/scripts/benchmark/benchmark.gyp View 1 chunk +8 lines, -6 lines 0 comments Download
M syzygy/scripts/benchmark/optimize.py View 4 chunks +9 lines, -4 lines 0 comments Download
M syzygy/scripts/benchmark/setup.py View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Siggi
6 years, 3 months ago (2011-07-07 21:57:22 UTC) #1
chrisha
lgtm http://codereview.appspot.com/4662082/diff/1/syzygy/scripts/benchmark/setup.py File syzygy/scripts/benchmark/setup.py (right): http://codereview.appspot.com/4662082/diff/1/syzygy/scripts/benchmark/setup.py#newcode82 syzygy/scripts/benchmark/setup.py:82: install_requires = [ Inconsistentcy in spacing around '=' ...
6 years, 3 months ago (2011-07-08 13:15:00 UTC) #2
Roger McFarlane
6 years, 3 months ago (2011-07-08 14:26:34 UTC) #3
lgtm

Good eye, Chris!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted