Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(600)

Issue 4644051: code review 4644051: test: A set of scalability benchmarks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 6 months ago
Reviewers:
rsc, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

test: A set of scalability benchmarks. See README file for details.

Patch Set 1 #

Patch Set 2 : diff -r 6f1145ee588d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6f1145ee588d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 6f1145ee588d https://go.googlecode.com/hg/ #

Total comments: 5

Patch Set 5 : diff -r 6f1145ee588d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1523 lines, -0 lines) Patch
A test/scale/Makefile View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A test/scale/README View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A test/scale/channel.go View 1 2 3 4 1 chunk +169 lines, -0 lines 0 comments Download
A test/scale/condvar.go View 1 2 3 4 1 chunk +108 lines, -0 lines 0 comments Download
A test/scale/draw.go View 1 1 chunk +189 lines, -0 lines 0 comments Download
A test/scale/driver.go View 1 1 chunk +133 lines, -0 lines 0 comments Download
A test/scale/goroutine.go View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A test/scale/matmult.go View 1 2 3 4 1 chunk +227 lines, -0 lines 0 comments Download
A test/scale/mutex.go View 1 2 3 4 1 chunk +92 lines, -0 lines 0 comments Download
A test/scale/once.go View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A test/scale/pingpong.go View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A test/scale/rwmutex.go View 1 2 3 4 1 chunk +110 lines, -0 lines 0 comments Download
A test/scale/sem.go View 1 2 3 4 1 chunk +122 lines, -0 lines 0 comments Download
A test/scale/timing.log View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
A test/scale/waitgroup.go View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 17
dvyukov
Hello golang-dev@googlegroups.com (cc: dvyukov@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2011-06-20 16:43:53 UTC) #1
bradfitz
http://codereview.appspot.com/4644051/diff/4001/test/scale/README File test/scale/README (right): http://codereview.appspot.com/4644051/diff/4001/test/scale/README#newcode2 test/scale/README:2: sync.Once implementation and estimate it's impact on performance/scalability. its, ...
10 years, 7 months ago (2011-06-20 16:58:30 UTC) #2
dvyukov
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: dvyukov@google.com, golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2011-06-20 19:34:40 UTC) #3
dvyukov
On 2011/06/20 16:58:30, bradfitz wrote: > http://codereview.appspot.com/4644051/diff/4001/test/scale/README > File test/scale/README (right): > > http://codereview.appspot.com/4644051/diff/4001/test/scale/README#newcode2 > ...
10 years, 7 months ago (2011-06-20 19:37:09 UTC) #4
rsc
I stopped after the first source file. Please make these benchmarks look like any other ...
10 years, 7 months ago (2011-06-20 19:40:38 UTC) #5
dvyukov
Hello bradfitz@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2011-06-21 09:32:53 UTC) #6
dvyukov
On 2011/06/20 19:40:38, rsc wrote: > I stopped after the first source file. > Please ...
10 years, 7 months ago (2011-06-21 09:48:37 UTC) #7
rsc
> First, it does not support variation of GOMAXPROCS. I would have to > create ...
10 years, 7 months ago (2011-06-21 16:20:00 UTC) #8
dvyukov
I do not mind improving gotest. I will post the proposal to golang-nuts. I will ...
10 years, 7 months ago (2011-06-22 11:52:12 UTC) #9
rsc
On Wed, Jun 22, 2011 at 07:52, <dvyukov@google.com> wrote: > I do not mind improving ...
10 years, 7 months ago (2011-06-22 14:52:30 UTC) #10
dvyukov
On 2011/06/22 14:52:30, rsc wrote: > On Wed, Jun 22, 2011 at 07:52, <mailto:dvyukov@google.com> wrote: ...
10 years, 7 months ago (2011-06-22 14:54:15 UTC) #11
dvyukov
Russ, I guess the next step after we land gotest changes is to rewrite the ...
10 years, 7 months ago (2011-06-23 12:29:43 UTC) #12
rsc
> I guess the next step after we land gotest changes is to rewrite the ...
10 years, 6 months ago (2011-06-27 13:16:37 UTC) #13
dvyukov
Thanks! Works for me!
10 years, 6 months ago (2011-06-27 13:36:06 UTC) #14
dvyukov
*** Abandoned ***
10 years, 6 months ago (2011-06-28 10:16:30 UTC) #15
dvyukov
On 2011/06/21 16:20:00, rsc wrote: > > First, it does not support variation of GOMAXPROCS. ...
10 years, 6 months ago (2011-06-28 10:18:00 UTC) #16
rsc
10 years, 6 months ago (2011-06-28 12:08:05 UTC) #17
Thank you for being so open to suggestions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b