Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 4644042: Implementation of ObjectMap, to add a map to the attribute system instead of a vector

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Jaume Nin
Modified:
10 years, 10 months ago
Reviewers:
Mathieu Lacage
CC:
tomh_tomh.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -6 lines) Patch
M src/config-store/model/attribute-iterator.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/config-store/model/attribute-iterator.cc View 4 chunks +78 lines, -2 lines 0 comments Download
M src/config-store/model/model-node-creator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/config-store/model/model-node-creator.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/core/model/config.cc View 4 chunks +43 lines, -1 line 0 comments Download
A src/core/model/object-map.h View 1 chunk +248 lines, -0 lines 0 comments Download
A src/core/model/object-map.cc View 1 chunk +130 lines, -0 lines 0 comments Download
M src/core/test/attribute-test-suite.cc View 6 chunks +104 lines, -3 lines 0 comments Download
M src/core/wscript View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Mathieu Lacage
what exactly is the rationale for this proposal ? i.e., what are you trying to ...
10 years, 12 months ago (2011-07-06 23:17:22 UTC) #1
Jaume Nin
Dear Mathieu, The simple rationale behind this is that in LENA we had several maps ...
10 years, 12 months ago (2011-07-07 09:42:27 UTC) #2
Mathieu Lacage
10 years, 10 months ago (2011-08-10 15:50:44 UTC) #3
The implementation looked way too much like a copy/pasted version of
ObjectVector so I refactored the code in ns-3-dev to make room for a new
ObjectMap thing. Please, test ns-3-dev and add relevant tests in
src/core/test/attribute-test-suite.cc.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b