Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(726)

Issue 4643058: code review 4643058: document release.r58 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by adg
Modified:
11 years, 5 months ago
Reviewers:
CC:
rsc, r, bsiegert, golang-dev
Visibility:
Public.

Description

document release.r58

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r e2dd614a21df https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 3 : diff -r e2dd614a21df https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e2dd614a21df https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6be4b9ad7991 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r 8fe2bc5c3d53 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 659e9b480d1d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M doc/devel/release.html View 1 2 3 4 5 1 chunk +72 lines, -0 lines 0 comments Download
M doc/devel/weekly.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2011-06-28 07:34:46 UTC) #1
bsiegert
http://codereview.appspot.com/4643058/diff/1/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4643058/diff/1/doc/devel/release.html#newcode60 doc/devel/release.html:60: <a href="/pkg/strconv/">Package strconv</a>'s <a href="/pkg/strconv/#Quote"> Quote</a> function
11 years, 5 months ago (2011-06-28 10:07:06 UTC) #2
adg
Hello rsc@golang.org, r@golang.org, bsiegert@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 5 months ago (2011-06-29 05:16:50 UTC) #3
r
LGTM
11 years, 5 months ago (2011-06-29 05:19:53 UTC) #4
rsc
http://codereview.appspot.com/4643058/diff/4001/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4643058/diff/4001/doc/devel/release.html#newcode20 doc/devel/release.html:20: TODO(rsc/lvd): Say something about append optimizations? Nah. http://codereview.appspot.com/4643058/diff/4001/doc/devel/release.html#newcode32 doc/devel/release.html:32: ...
11 years, 5 months ago (2011-06-29 05:20:43 UTC) #5
adg
Hello rsc@golang.org, r@golang.org, bsiegert@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 5 months ago (2011-06-29 05:32:54 UTC) #6
adg
Gotta mention os/signal changes, too.
11 years, 5 months ago (2011-06-29 05:48:00 UTC) #7
adg
Hello rsc@golang.org, r@golang.org, bsiegert@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 5 months ago (2011-06-29 06:08:32 UTC) #8
r
http://codereview.appspot.com/4643058/diff/8/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4643058/diff/8/doc/devel/release.html#newcode53 doc/devel/release.html:53: <a href="/pkg/exec/">Package exec</a> has been re-designed with a more ...
11 years, 5 months ago (2011-06-29 06:59:59 UTC) #9
r
LGTM
11 years, 5 months ago (2011-06-29 07:00:09 UTC) #10
rsc
LGTM
11 years, 5 months ago (2011-06-29 23:44:14 UTC) #11
adg
11 years, 5 months ago (2011-06-29 23:45:18 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=0a5e3e664637 ***

document release.r58

R=rsc, r, bsiegert
CC=golang-dev
http://codereview.appspot.com/4643058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b