Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 4641092: Revamped linear order generator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by chrisha
Modified:
6 years, 3 months ago
Reviewers:
Roger McFarlane, Siggi
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Revamped linear order generator Extended the reorderer base class to parse process information, allowing it to distinguish between multiple runs of an instrumented module in a single ETL file, as well as multiple runs across multiple ETL files. Extended LinearOrderGenerator to use this information. The generalized behaviour of LinearOrderGenerator is to group function calls by popularity, and linearize their order of access. This is equivalent to the previous behaviour for cases where there is only a single run of the instrumented module. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk375

Patch Set 1 : '' #

Total comments: 6

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -74 lines) Patch
M syzygy/reorder/linear_order_generator.h View 1 3 chunks +73 lines, -7 lines 1 comment Download
M syzygy/reorder/linear_order_generator.cc View 1 2 chunks +192 lines, -57 lines 0 comments Download
M syzygy/reorder/reorderer.h View 7 chunks +30 lines, -2 lines 0 comments Download
M syzygy/reorder/reorderer.cc View 6 chunks +56 lines, -8 lines 0 comments Download

Messages

Total messages: 8
chrisha
PTAL
6 years, 3 months ago (2011-07-04 20:53:31 UTC) #1
chrisha
ping!
6 years, 3 months ago (2011-07-05 13:27:33 UTC) #2
Siggi
lgtm, except I'd really like to see an overview document on the "what" of this ...
6 years, 3 months ago (2011-07-05 13:34:30 UTC) #3
Roger McFarlane
Perhaps this should be an alternative to the original linear ordering, instead of a replacement ...
6 years, 3 months ago (2011-07-05 13:49:11 UTC) #4
chrisha
Addressed siggi's nits. As for making this a separate reorderer, it's an extension of functionality ...
6 years, 3 months ago (2011-07-05 14:24:49 UTC) #5
Siggi
lgtm still :) http://codereview.appspot.com/4641092/diff/8001/syzygy/reorder/linear_order_generator.h File syzygy/reorder/linear_order_generator.h (right): http://codereview.appspot.com/4641092/diff/8001/syzygy/reorder/linear_order_generator.h#newcode26 syzygy/reorder/linear_order_generator.h:26: // of blocks that were only ...
6 years, 3 months ago (2011-07-05 14:30:19 UTC) #6
Roger McFarlane
lgtm On 5 July 2011 10:30, <siggi@chromium.org> wrote: > lgtm still :) > > > ...
6 years, 3 months ago (2011-07-05 14:31:46 UTC) #7
chrisha
6 years, 3 months ago (2011-07-05 16:40:09 UTC) #8
Thanks, committing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted