Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 4635063: code review 4635063: mime/multipart: remove newline at top of the multipart. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by mattn
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev_googlecode.com, bradfitz, cainetighe, golang-dev
Visibility:
Public.

Description

mime/multipart: remove newline at top of the multipart.

Patch Set 1 #

Patch Set 2 : diff -r 57985f90a7d8 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 57985f90a7d8 http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 994436b726dd https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 994436b726dd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/pkg/mime/multipart/writer.go View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/pkg/mime/multipart/writer_test.go View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mattn
Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
11 years, 3 months ago (2011-06-23 09:41:22 UTC) #1
bradfitz
Why? I can't imagine this breaks anything. Lots of multipart implementations start with a banner ...
11 years, 3 months ago (2011-06-23 15:24:43 UTC) #2
cainetighe
I would tend to agree with Brad on this one. The cleaner code is not ...
11 years, 3 months ago (2011-06-23 15:45:27 UTC) #3
bradfitz
Okay. Well, if it's worth fixing to work-around a bug in Rack, it's worth adding ...
11 years, 3 months ago (2011-06-23 16:25:25 UTC) #4
mattn
Hello golang-dev@googlecode.com, bradfitz@golang.org, arctanofyourface@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2011-06-23 16:33:13 UTC) #5
bradfitz
11 years, 3 months ago (2011-06-23 17:11:51 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=c5ff902a17b9 ***

mime/multipart: remove newline at top of the multipart.

R=golang-dev, bradfitz, arctanofyourface
CC=golang-dev
http://codereview.appspot.com/4635063

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b