Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 4631051: Automate the process of optimizing and benchmarking Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by Siggi
Modified:
6 years, 3 months ago
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Automate the process of optimizing and benchmarking Chrome. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk379

Patch Set 1 : '' #

Total comments: 22

Patch Set 2 : Address Roger's and Chris' nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -57 lines) Patch
M syzygy/scripts/benchmark/benchmark.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
A syzygy/scripts/benchmark/optimize.py View 1 1 chunk +219 lines, -0 lines 0 comments Download
M syzygy/scripts/benchmark/runner.py View 1 7 chunks +54 lines, -56 lines 0 comments Download
M syzygy/scripts/benchmark/setup.py View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6
Siggi
6 years, 3 months ago (2011-07-07 14:11:07 UTC) #1
chrisha
lgtm, with a few questions. http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py File syzygy/scripts/benchmark/optimize.py (right): http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py#newcode78 syzygy/scripts/benchmark/optimize.py:78: self._call_trace_logger.EnableProvider(_CALL_TRACE_PROVIDER, All of this ...
6 years, 3 months ago (2011-07-07 14:22:29 UTC) #2
Roger McFarlane
http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py File syzygy/scripts/benchmark/optimize.py (right): http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py#newcode15 syzygy/scripts/benchmark/optimize.py:15: from etw.guiddef import GUID docstring http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py#newcode125 syzygy/scripts/benchmark/optimize.py:125: file) raise ...
6 years, 3 months ago (2011-07-07 14:58:16 UTC) #3
Siggi
Thanks, PTAL. http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py File syzygy/scripts/benchmark/optimize.py (right): http://codereview.appspot.com/4631051/diff/16001/syzygy/scripts/benchmark/optimize.py#newcode15 syzygy/scripts/benchmark/optimize.py:15: from etw.guiddef import GUID On 2011/07/07 14:58:16, ...
6 years, 3 months ago (2011-07-07 18:30:26 UTC) #4
Roger McFarlane
lgtm
6 years, 3 months ago (2011-07-07 20:07:04 UTC) #5
chrisha
6 years, 3 months ago (2011-07-07 20:07:19 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted