Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(909)

Issue 4601052: code review 4601052: weekly.2011-06-09 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by adg
Modified:
11 years, 6 months ago
Reviewers:
dfc
CC:
golang-dev, r2
Visibility:
Public.

Description

weekly.2011-06-09

Patch Set 1 #

Patch Set 2 : diff -r bc0e6f3c2574 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -8 lines) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 6 chunks +65 lines, -7 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2011-06-10 04:13:13 UTC) #1
r2
LGTM
11 years, 6 months ago (2011-06-10 04:16:14 UTC) #2
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=c81944152e97 *** weekly.2011-06-09 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4601052
11 years, 6 months ago (2011-06-10 04:26:16 UTC) #3
dfc
Please don't overlook Howard Fans VSQRT work. http://code.google.com/p/go/source/detail?r=002945af78ccbfa51b7fe6eebe883ab9663c9f3a Cheers Dave On Fri, Jun 10, 2011 ...
11 years, 6 months ago (2011-06-10 04:34:30 UTC) #4
adg
11 years, 6 months ago (2011-06-10 04:54:00 UTC) #5
* arm: floating point improvements (thanks Fan Hongjian).

On 10 June 2011 14:34, Dave Cheney <dave@cheney.net> wrote:
> Please don't overlook Howard Fans VSQRT work.
>
>
http://code.google.com/p/go/source/detail?r=002945af78ccbfa51b7fe6eebe883ab96...
>
> Cheers
>
> Dave
>
> On Fri, Jun 10, 2011 at 2:26 PM,  <adg@golang.org> wrote:
>> *** Submitted as
>> http://code.google.com/p/go/source/detail?r=c81944152e97 ***
>>
>> weekly.2011-06-09
>>
>> R=golang-dev, r
>> CC=golang-dev
>> http://codereview.appspot.com/4601052
>>
>>
>> http://codereview.appspot.com/4601052/
>>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b