Issue 4601052: code review 4601052: weekly.2011-06-09

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4601052: code review 4601052: weekly.2011-06-09 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by adg

Modified:
12 years, 10 months ago

Reviewers:
dave

CC:
golang-dev, r2

Visibility:
Public.

Description

weekly.2011-06-09

Patch Set 1 #

Patch Set 2 : diff -r bc0e6f3c2574 https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -8 lines)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View		6 chunks	+65 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-10 04:13:13 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=c81944152e97 *** weekly.2011-06-09 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4601052

12 years, 10 months ago (2011-06-10 04:26:16 UTC) #3

dave_cheney.net

Please don't overlook Howard Fans VSQRT work. http://code.google.com/p/go/source/detail?r=002945af78ccbfa51b7fe6eebe883ab9663c9f3a Cheers Dave On Fri, Jun 10, 2011 ...

12 years, 10 months ago (2011-06-10 04:34:30 UTC) #4

adg

12 years, 10 months ago (2011-06-10 04:54:00 UTC) #5

* arm: floating point improvements (thanks Fan Hongjian).

On 10 June 2011 14:34, Dave Cheney <dave@cheney.net> wrote:
> Please don't overlook Howard Fans VSQRT work.
>
>
http://code.google.com/p/go/source/detail?r=002945af78ccbfa51b7fe6eebe883ab96...
>
> Cheers
>
> Dave
>
> On Fri, Jun 10, 2011 at 2:26 PM,  <adg@golang.org> wrote:
>> *** Submitted as
>> http://code.google.com/p/go/source/detail?r=c81944152e97 ***
>>
>> weekly.2011-06-09
>>
>> R=golang-dev, r
>> CC=golang-dev
>> http://codereview.appspot.com/4601052
>>
>>
>> http://codereview.appspot.com/4601052/
>>
>

Expand All Messages | Collapse All Messages