Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(867)

Issue 4590050: code review 4590050: net, syscall: interface for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by mattn
Modified:
12 years, 1 month ago
Reviewers:
CC:
mikio, brainman, rsc, vincent.vanackere, golang-dev
Visibility:
Public.

Description

net, syscall: interface for windows

Patch Set 1 #

Patch Set 2 : diff -r 71776ebc7416 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 71776ebc7416 http://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 4 : diff -r 3180ac267d3d http://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b64827a86cf9 http://go.googlecode.com/hg/ #

Patch Set 6 : diff -r b64827a86cf9 http://go.googlecode.com/hg/ #

Patch Set 7 : diff -r dc2faaa6c26a http://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 8 : diff -r d86f80185297 http://go.googlecode.com/hg/ #

Patch Set 9 : diff -r d86f80185297 http://go.googlecode.com/hg/ #

Patch Set 10 : diff -r cf1155385bb7 http://go.googlecode.com/hg/ #

Patch Set 11 : diff -r cf1155385bb7 http://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 12 : diff -r 78a6b3731880 http://go.googlecode.com/hg/ #

Patch Set 13 : diff -r 78a6b3731880 http://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 14 : diff -r 6c9c33c799f1 http://go.googlecode.com/hg/ #

Patch Set 15 : diff -r 6c9c33c799f1 http://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 16 : diff -r 12cc5b3cc379 http://go.googlecode.com/hg/ #

Total comments: 25

Patch Set 17 : diff -r e3c9fecaef4e http://go.googlecode.com/hg/ #

Patch Set 18 : diff -r e3c9fecaef4e http://go.googlecode.com/hg/ #

Total comments: 20

Patch Set 19 : diff -r 6e3e06fb2dc3 http://go.googlecode.com/hg/ #

Patch Set 20 : diff -r 6e3e06fb2dc3 http://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 21 : diff -r 6e3e06fb2dc3 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -2 lines) Patch
M src/pkg/net/Makefile View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/net/interface_windows.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +152 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +31 lines, -1 line 0 comments Download
M src/pkg/syscall/ztypes_windows_386.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 44
mattn
Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
12 years, 9 months ago (2011-06-10 09:50:52 UTC) #1
mikio
CL description: net, syscall: interface for windows might be better. http://codereview.appspot.com/4590050/diff/4001/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/4001/src/pkg/net/interface_windows.go#newcode5 ...
12 years, 9 months ago (2011-06-10 12:24:03 UTC) #2
mattn
Thank you for your review. http://codereview.appspot.com/4590050/diff/4001/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/4001/src/pkg/net/interface_windows.go#newcode5 src/pkg/net/interface_windows.go:5: // Network interface identification ...
12 years, 9 months ago (2011-06-10 12:34:53 UTC) #3
mattn
Hello golang-dev@googlecode.com, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-13 00:56:50 UTC) #4
brainman
On 2011/06/13 00:56:50, mattn wrote: > Hello mailto:golang-dev@googlecode.com, mailto:mikioh.mikioh@gmail.com (cc: > mailto:golang-dev@googlegroups.com), > > Please ...
12 years, 9 months ago (2011-06-14 02:57:10 UTC) #5
mattn
I updated CL. All of function that manipulating Interface/Addr are confined to interface_windows.go This should ...
12 years, 9 months ago (2011-06-14 08:48:21 UTC) #6
rsc
Thanks for fixing this. http://codereview.appspot.com/4590050/diff/9006/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/9006/src/pkg/net/interface_windows.go#newcode270 src/pkg/net/interface_windows.go:270: //sys getAdaptersAddresses(family uint32, flags uint32, ...
12 years, 9 months ago (2011-06-14 15:25:48 UTC) #7
mattn
I did't do really checking. I checked this patch with specifyign isWin2k = true forcely ...
12 years, 9 months ago (2011-06-15 00:12:11 UTC) #8
mattn
On 2011/06/15 00:12:11, mattn wrote: > I did't do really checking. > > I checked ...
12 years, 9 months ago (2011-06-15 00:55:24 UTC) #9
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-15 01:08:46 UTC) #10
brainman
I tested your "win2k" version here. And it works just fine. TestInterface* tests list my ...
12 years, 9 months ago (2011-06-15 01:32:48 UTC) #11
mattn
On 2011/06/15 01:32:48, brainman wrote: > I tested your "win2k" version here. And it works ...
12 years, 9 months ago (2011-06-15 01:52:59 UTC) #12
brainman
On 2011/06/15 01:52:59, mattn wrote: > > interfaceTable2 is using GetAdaptersAddresses() ... I propose we ...
12 years, 9 months ago (2011-06-15 02:08:56 UTC) #13
mattn
On 2011/06/15 02:08:56, brainman wrote: > On 2011/06/15 01:52:59, mattn wrote: > > > > ...
12 years, 9 months ago (2011-06-15 02:30:55 UTC) #14
brainman
On 2011/06/15 02:30:55, mattn wrote: > > BTW, We may have to think about delay ...
12 years, 9 months ago (2011-06-15 02:39:38 UTC) #15
mattn
On 2011/06/15 02:39:38, brainman wrote: > On 2011/06/15 02:30:55, mattn wrote: > > > > ...
12 years, 9 months ago (2011-06-15 04:52:10 UTC) #16
mattn
On 2011/06/15 02:08:56, brainman wrote: > On 2011/06/15 01:52:59, mattn wrote: > > > > ...
12 years, 9 months ago (2011-06-15 04:52:32 UTC) #17
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-15 04:52:44 UTC) #18
mikio
http://codereview.appspot.com/4590050/diff/13007/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/13007/src/pkg/net/interface_windows.go#newcode18 src/pkg/net/interface_windows.go:18: if ifi == nil { Interface struct no longer ...
12 years, 9 months ago (2011-06-15 10:59:25 UTC) #19
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-15 11:16:09 UTC) #20
mattn
Thank you http://codereview.appspot.com/4590050/diff/13007/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/13007/src/pkg/net/interface_windows.go#newcode18 src/pkg/net/interface_windows.go:18: if ifi == nil { On 2011/06/15 ...
12 years, 9 months ago (2011-06-15 11:16:40 UTC) #21
vincent.vanackere
On Wed, Jun 15, 2011 at 4:08 AM, <alex.brainman@gmail.com> wrote: > On 2011/06/15 01:52:59, mattn ...
12 years, 9 months ago (2011-06-15 12:43:29 UTC) #22
mikio
http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go#newcode71 src/pkg/net/interface_windows.go:71: if row.OperStatus == syscall.IF_OPER_STATUS_CONNECTED || row.OperStatus == syscall.IF_OPER_STATUS_OPERATIONAL || ...
12 years, 9 months ago (2011-06-15 13:24:22 UTC) #23
mattn
http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go#newcode71 src/pkg/net/interface_windows.go:71: if row.OperStatus == syscall.IF_OPER_STATUS_CONNECTED || row.OperStatus == syscall.IF_OPER_STATUS_OPERATIONAL || ...
12 years, 9 months ago (2011-06-15 17:02:52 UTC) #24
mattn
http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/12009/src/pkg/net/interface_windows.go#newcode71 src/pkg/net/interface_windows.go:71: if row.OperStatus == syscall.IF_OPER_STATUS_CONNECTED || row.OperStatus == syscall.IF_OPER_STATUS_OPERATIONAL || ...
12 years, 9 months ago (2011-06-16 00:31:02 UTC) #25
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org, vincent.vanackere@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-16 00:31:34 UTC) #26
mikio
LGTM. I'll leave it to Windows experts because I saw the reliable evidence of many ...
12 years, 9 months ago (2011-06-17 01:05:45 UTC) #27
mattn
I found the way to get interface flags. Then, I updated drastic. On 2011/06/17 01:05:45, ...
12 years, 9 months ago (2011-06-17 06:38:07 UTC) #28
mikio
http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go#newcode16 src/pkg/net/interface_windows.go:16: func bytePtrToString(p *uint8) string { Seems like not the ...
12 years, 9 months ago (2011-06-17 10:42:32 UTC) #29
mattn
On 2011/06/17 10:42:32, mikioh wrote: > http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go > File src/pkg/net/interface_windows.go (right): > > http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go#newcode16 > ...
12 years, 9 months ago (2011-06-17 10:49:38 UTC) #30
mikio
> bytePtrToString/utf16PtrToString is using pointer. not slice or array. > It seems that is bits ...
12 years, 9 months ago (2011-06-17 12:30:42 UTC) #31
mikio
> To me, there is no reason to make a new... no reason you won't ...
12 years, 9 months ago (2011-06-17 13:07:15 UTC) #32
mattn
On 2011/06/17 13:07:15, mikioh wrote: > > To me, there is no reason to make ...
12 years, 9 months ago (2011-06-17 15:21:16 UTC) #33
brainman
http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go#newcode54 src/pkg/net/interface_windows.go:54: } Replace the above by a call to something ...
12 years, 9 months ago (2011-06-22 01:30:37 UTC) #34
mattn
http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/38001/src/pkg/net/interface_windows.go#newcode16 src/pkg/net/interface_windows.go:16: func bytePtrToString(p *uint8) string { On 2011/06/17 10:42:32, mikioh ...
12 years, 9 months ago (2011-06-22 02:11:23 UTC) #35
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org, vincent.vanackere@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-22 02:11:50 UTC) #36
brainman
http://codereview.appspot.com/4590050/diff/36007/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/36007/src/pkg/net/interface_windows.go#newcode35 src/pkg/net/interface_windows.go:35: return nil, os.NewSyscallError("GetAdaptersInfo", int(e)) s/int(e)/e/ http://codereview.appspot.com/4590050/diff/36007/src/pkg/net/interface_windows.go#newcode43 src/pkg/net/interface_windows.go:43: return nil, ...
12 years, 9 months ago (2011-06-22 05:47:45 UTC) #37
mattn
http://codereview.appspot.com/4590050/diff/36007/src/pkg/net/interface_windows.go File src/pkg/net/interface_windows.go (right): http://codereview.appspot.com/4590050/diff/36007/src/pkg/net/interface_windows.go#newcode35 src/pkg/net/interface_windows.go:35: return nil, os.NewSyscallError("GetAdaptersInfo", int(e)) On 2011/06/22 05:47:45, brainman wrote: ...
12 years, 9 months ago (2011-06-22 06:15:35 UTC) #38
mattn
Hello mikioh.mikioh@gmail.com, alex.brainman@gmail.com, rsc@golang.org, vincent.vanackere@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-22 06:16:09 UTC) #39
brainman
LGTM. http://codereview.appspot.com/4590050/diff/33004/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/4590050/diff/33004/src/pkg/syscall/syscall_windows.go#newcode471 src/pkg/syscall/syscall_windows.go:471: //sys WSAIoctl(s int32, iocc uint32, inbuf *byte, cbif ...
12 years, 9 months ago (2011-06-22 07:08:44 UTC) #40
mattn
http://codereview.appspot.com/4590050/diff/33004/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/4590050/diff/33004/src/pkg/syscall/syscall_windows.go#newcode471 src/pkg/syscall/syscall_windows.go:471: //sys WSAIoctl(s int32, iocc uint32, inbuf *byte, cbif uint32, ...
12 years, 9 months ago (2011-06-22 07:17:07 UTC) #41
brainman
More comments anyone? If no more takers, I'll submit this. Alex
12 years, 9 months ago (2011-06-22 23:50:19 UTC) #42
rsc
LGTM I'm happy if everyone else is.
12 years, 9 months ago (2011-06-22 23:52:23 UTC) #43
brainman
12 years, 9 months ago (2011-06-22 23:55:06 UTC) #44
*** Submitted as http://code.google.com/p/go/source/detail?r=6adcc9f52615 ***

net, syscall: interface for windows

R=mikioh.mikioh, alex.brainman, rsc, vincent.vanackere
CC=golang-dev
http://codereview.appspot.com/4590050

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b