Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 4571074: code review 4571074: unicode: add case folding tables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
CC:
r, r2, golang-dev
Visibility:
Public.

Description

unicode: add case folding tables

Patch Set 1 #

Patch Set 2 : diff -r ecb31be11487 https://go.googlecode.com/hg #

Patch Set 3 : diff -r ecb31be11487 https://go.googlecode.com/hg #

Patch Set 4 : diff -r ecb31be11487 https://go.googlecode.com/hg #

Patch Set 5 : diff -r ecb31be11487 https://go.googlecode.com/hg #

Total comments: 17

Patch Set 6 : diff -r f5d2325ee229 https://go.googlecode.com/hg #

Patch Set 7 : diff -r f5d2325ee229 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 8 : diff -r f5d2325ee229 https://go.googlecode.com/hg #

Patch Set 9 : diff -r f5d2325ee229 https://go.googlecode.com/hg #

Patch Set 10 : diff -r 894b438b8564 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -109 lines) Patch
M src/pkg/unicode/letter.go View 1 2 3 4 5 6 7 8 1 chunk +49 lines, -0 lines 0 comments Download
M src/pkg/unicode/letter_test.go View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
M src/pkg/unicode/maketables.go View 1 2 3 4 5 6 7 8 7 chunks +293 lines, -8 lines 0 comments Download
M src/pkg/unicode/tables.go View 1 2 3 4 5 6 7 8 4 chunks +533 lines, -101 lines 0 comments Download

Messages

Total messages: 15
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
12 years, 9 months ago (2011-06-14 22:23:21 UTC) #1
rsc
for regexp. most of the space is for the Ll and Lu exception tables. i ...
12 years, 9 months ago (2011-06-14 22:27:33 UTC) #2
r
quick comments. i'll give another pass a little later http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go File src/pkg/unicode/letter.go (right): http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go#newcode281 src/pkg/unicode/letter.go:281: ...
12 years, 9 months ago (2011-06-14 22:31:33 UTC) #3
r
code looks good but needs the self-check test http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go File src/pkg/unicode/letter.go (right): http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go#newcode282 src/pkg/unicode/letter.go:282: func ...
12 years, 9 months ago (2011-06-15 02:01:02 UTC) #4
rsc
On Tue, Jun 14, 2011 at 22:01, <r@golang.org> wrote: > code looks good but needs ...
12 years, 9 months ago (2011-06-15 02:16:10 UTC) #5
r2
On Jun 15, 2011, at 12:15 PM, Russ Cox wrote: > On Tue, Jun 14, ...
12 years, 9 months ago (2011-06-15 03:13:40 UTC) #6
rsc
Hello r@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-16 19:20:03 UTC) #7
rsc
http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go File src/pkg/unicode/letter.go (right): http://codereview.appspot.com/4571074/diff/2011/src/pkg/unicode/letter.go#newcode281 src/pkg/unicode/letter.go:281: // ``simple case folding'' and returns the resulting slice. ...
12 years, 9 months ago (2011-06-16 19:23:07 UTC) #8
r
LGTM http://codereview.appspot.com/4571074/diff/15001/src/pkg/unicode/letter.go File src/pkg/unicode/letter.go (right): http://codereview.appspot.com/4571074/diff/15001/src/pkg/unicode/letter.go#newcode289 src/pkg/unicode/letter.go:289: // the ``simple case folding.'' Among the code ...
12 years, 9 months ago (2011-06-16 21:23:24 UTC) #9
rsc
On Thu, Jun 16, 2011 at 17:23, <r@golang.org> wrote: > LGTM > > > > ...
12 years, 9 months ago (2011-06-16 21:40:04 UTC) #10
r2
On 17/06/2011, at 7:40 AM, Russ Cox wrote: > On Thu, Jun 16, 2011 at ...
12 years, 9 months ago (2011-06-16 21:47:30 UTC) #11
rsc
dropped `` '' added Unicode-defined
12 years, 9 months ago (2011-06-16 21:53:05 UTC) #12
rsc
Hello r@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-16 21:53:22 UTC) #13
r
LGTM
12 years, 9 months ago (2011-06-16 21:55:51 UTC) #14
rsc
12 years, 9 months ago (2011-06-16 21:56:32 UTC) #15
*** Submitted as http://code.google.com/p/go/source/detail?r=3a81409b9013 ***

unicode: add case folding tables

R=r, r
CC=golang-dev
http://codereview.appspot.com/4571074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b