Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(233)

Issue 4547058: Allows LilyPond to ignore certain note-heads in a stem. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by MikeSol
Modified:
7 years, 11 months ago
Reviewers:
mike, Graham Percival (old account), Neil Puttock, Graham Percival, t.daniels, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allows LilyPond to ignore certain note-heads in a stem.

Patch Set 1 : Allows LilyPond to ignore certain note-heads in a stem. #

Patch Set 2 : Uses stem-attachment to control if a note is attached or not #

Patch Set 3 : Respects stem attachment for fa note-head #

Patch Set 4 : Changes get_property to get_property_data #

Patch Set 5 : Fixes segfault. #

Patch Set 6 : Better segfault support #

Patch Set 7 : Fixes segfault for beams. #

Total comments: 1

Patch Set 8 : Fixes segfault via the Stem engraver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M lily/note-collision.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M lily/stem.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M lily/stem-engraver.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M lily/tie-formatting-problem.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19
MikeSol
I put this together to do some work with harmonics. It seems to do the ...
7 years, 12 months ago (2011-05-22 07:38:17 UTC) #1
t.daniels_treda.co.uk
Hi Mike The interface to this looks rather clumsy. As you want to ignore only ...
7 years, 12 months ago (2011-05-22 08:10:33 UTC) #2
mike_apollinemike.com
On May 22, 2011, at 10:10 AM, Trevor Daniels wrote: > Hi Mike > > ...
7 years, 12 months ago (2011-05-22 08:25:01 UTC) #3
Carl
What if instead of setting a boolean stem-ignore, you just set stem-attachment = ##f in ...
7 years, 12 months ago (2011-05-22 13:23:43 UTC) #4
mike_apollinemike.com
On May 22, 2011, at 3:23 PM, Carl.D.Sorensen@gmail.com wrote: > > What if instead of ...
7 years, 12 months ago (2011-05-22 17:01:55 UTC) #5
MikeSol
Just touching base to see if people felt this patch is pushable after the changes ...
7 years, 11 months ago (2011-05-28 08:23:19 UTC) #6
Graham Percival
On Sat, May 28, 2011 at 08:23:19AM +0000, mtsolo@gmail.com wrote: > Just touching base to ...
7 years, 11 months ago (2011-05-28 12:01:05 UTC) #7
Carl
Do we need to change the definition of stem-attachment in scm/define-grobs.scm to be ,boolean-or-number-pair? (and ...
7 years, 11 months ago (2011-05-28 13:28:52 UTC) #8
mike_apollinemike.com
On May 28, 2011, at 2:28 PM, Carl.D.Sorensen@gmail.com wrote: > Do we need to change ...
7 years, 11 months ago (2011-05-31 06:59:21 UTC) #9
Graham Percival (old account)
On 2011/05/31 06:59:21, mike_apollinemike.com wrote: > Graham, could you include this in your next countdown? ...
7 years, 11 months ago (2011-05-31 12:39:03 UTC) #10
MikeSol
On 2011/05/31 12:39:03, Graham Percival wrote: > On 2011/05/31 06:59:21, http://mike_apollinemike.com wrote: > > Graham, ...
7 years, 11 months ago (2011-05-31 15:34:44 UTC) #11
Neil Puttock
Hi Mike, Have you considered what might happen if a user tries to get rid ...
7 years, 11 months ago (2011-05-31 16:33:22 UTC) #12
MikeSol
On 2011/05/31 16:33:22, Neil Puttock wrote: > Hi Mike, > > Have you considered what ...
7 years, 11 months ago (2011-05-31 23:04:36 UTC) #13
MikeSol
> Hey Neil, > > I think this does the trick. > > Cheers, > ...
7 years, 11 months ago (2011-06-01 07:39:32 UTC) #14
Graham Percival (old account)
LGTM
7 years, 11 months ago (2011-06-01 13:17:51 UTC) #15
Neil Puttock
I'm afraid it's still a bit flaky: \relative c' { \override NoteHead #'stem-attachment = ##f ...
7 years, 11 months ago (2011-06-01 20:54:29 UTC) #16
mike_apollinemike.com
On Jun 1, 2011, at 10:54 PM, n.puttock@gmail.com wrote: > I'm afraid it's still a ...
7 years, 11 months ago (2011-06-02 10:39:22 UTC) #17
Neil Puttock
http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc#newcode439 lily/stem.cc:439: me->set_property ("stencil", SCM_BOOL_F); This looks like a hack; it's ...
7 years, 11 months ago (2011-06-02 18:55:10 UTC) #18
mike_apollinemike.com
7 years, 11 months ago (2011-06-03 15:27:22 UTC) #19
On Jun 2, 2011, at 8:55 PM, n.puttock@gmail.com wrote:

> 
> http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc
> File lily/stem.cc (right):
> 
> http://codereview.appspot.com/4547058/diff/7004/lily/stem.cc#newcode439
> lily/stem.cc:439: me->set_property ("stencil", SCM_BOOL_F);
> This looks like a hack; it's certainly not idiomatic (I can see only one
> place where a stencil is set in code, and in that case it's a valid
> stencil)
> 

I uploaded a new version that doesn't engrave a stem for a rhythmic head unless
the head has a stem attachment.  That seems to work - lemme know what you think!

Cheers,
MS

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b