Issue 4535055: Fixes the assert problem coming from ledger-line-spanner.cc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535055: Fixes the assert problem coming from ledger-line-spanner.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by MikeSol

Modified:
12 years, 11 months ago

Reviewers:
mike, carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fixes the assert problem coming from ledger-line-spanner.cc.

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/ledger-line-spanner.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSol

This seems like a quick, easy, and reasonable fix for Issue 1652. Lemme know if ...

12 years, 11 months ago (2011-05-12 20:06:59 UTC) #1

mike_apollinemike.com

12 years, 11 months ago (2011-05-12 23:30:53 UTC) #3

On May 12, 2011, at 4:08 PM, Carl.D.Sorensen@gmail.com wrote:

> LGTM.
> 
> Carl
> 
> 
> http://codereview.appspot.com/4535055/


Passes the regtests, so pushed as 69580da523384fc207043e4bad297d7560e24268.

Cheers,
MS

Expand All Messages | Collapse All Messages