Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 4534059: MIDI: default midiChannelMapping to 'staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Keith
Modified:
7 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

MIDI: default midiChannelMapping to 'staff Fix issue 1648

Patch Set 1 #

Patch Set 2 : add regression test #

Patch Set 3 : whitespace, document channelMapping=#'staff #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -6 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A input/regression/midi-notes.ly View 1 1 chunk +21 lines, -0 lines 0 comments Download
M input/regression/midi/key-initial.ly View 1 chunk +6 lines, -0 lines 1 comment Download
M input/regression/midi/key-option.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/lyrics-addlyrics.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/partcombine.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/quantize-duration.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/quantize-duration-2.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/quantize-start.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/rest.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/staff-map-instrument.ly View 1 chunk +1 line, -2 lines 0 comments Download
M input/regression/midi/voice-2.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/voice-4.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M input/regression/midi/voice-5.ly View 1 chunk +6 lines, -0 lines 0 comments Download
M ly/performer-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Graham Percival (old account)
looks fine, passes regtests. http://codereview.appspot.com/4534059/diff/9001/input/regression/midi/key-initial.ly File input/regression/midi/key-initial.ly (right): http://codereview.appspot.com/4534059/diff/9001/input/regression/midi/key-initial.ly#newcode2 input/regression/midi/key-initial.ly:2: \version "2.13.53" should this version ...
7 years, 11 months ago (2011-05-28 19:16:34 UTC) #1
Keith
On 2011/05/28 19:16:34, Graham Percival wrote: > input/regression/midi/key-initial.ly:2: \version "2.13.53" > should this version number ...
7 years, 10 months ago (2011-05-29 20:27:20 UTC) #2
Graham Percival
7 years, 10 months ago (2011-05-29 21:31:46 UTC) #3
On Sun, May 29, 2011 at 08:27:20PM +0000, k-ohara5a5a@oco.net wrote:
> Reviewers: Graham Percival,
> 
> Message:
> On 2011/05/28 19:16:34, Graham Percival wrote:
> >input/regression/midi/key-initial.ly:2: \version "2.13.53"
> >should this version number be increased?  Did we have
> midiChannelMapping in
> >version 2.13.53?
> 
> Wow. You must have quite detailed recall because midiChannelMapping
> appeared just 12 hours after 2.13.53.

Complete fluke!  I actually thought it was only added in .60 or
something like that, and I was trying to be politely vague about
the version number.  :)

Thanks, we'll have 2.13.63 (and the next release candidate)
tomorrow.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b