Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(171)

Issue 4517143: code review 4517143: gc: alternative clang compatible abort. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dfc
Modified:
10 years, 6 months ago
Reviewers:
CC:
rsc, jmhodges, r, golang-dev
Visibility:
Public.

Description

gc: alternative clang compatible abort. Tested on clang 2.9/amd64

Patch Set 1 #

Patch Set 2 : diff -r 082e18eba53b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 082e18eba53b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/subr.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
dfc
Hello rsc@golang.org, jeff@somethingsimilar.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2011-06-08 00:28:56 UTC) #1
jmhodges
LGTM
10 years, 6 months ago (2011-06-08 00:36:47 UTC) #2
r
LGTM
10 years, 6 months ago (2011-06-08 00:46:06 UTC) #3
r
*** Submitted as http://code.google.com/p/go/source/detail?r=58515a4de582 *** gc: alternative clang compatible abort. Tested on clang 2.9/amd64 R=rsc, ...
10 years, 6 months ago (2011-06-08 00:46:28 UTC) #4
rsc
10 years, 6 months ago (2011-06-08 02:43:58 UTC) #5
thank you!

for the curious, it's very common when trying to debug
a compiler bug to narrow it down to a single error being
printed and then run the compiler under gdb with the -h flag,
so that you get a fault at the time of the error, so that
you can poke around at the context.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b