Issue 4515078: aGoldPatch 2/20

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515078: aGoldPatch 2/20

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by jeckkech

Modified:
1 year, 3 months ago

Reviewers:
webdizz, mp.snoopy

CC:
zinur

Base URL:
http://svn2.xp-dev.com/svn/ags/trunk

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+607 lines, -4 lines)			Patch
		catalog/src/test/java/rba/pm/catalog/service/ListMetalServiceTest.java	View		5 chunks	+607 lines, -4 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

webdizz

http://codereview.appspot.com/4515078/diff/1/catalog/src/test/java/rba/pm/catalog/service/ListMetalServiceTest.java File catalog/src/test/java/rba/pm/catalog/service/ListMetalServiceTest.java (right): http://codereview.appspot.com/4515078/diff/1/catalog/src/test/java/rba/pm/catalog/service/ListMetalServiceTest.java#newcode31 catalog/src/test/java/rba/pm/catalog/service/ListMetalServiceTest.java:31: Refactor and avoid duplication

12 years, 11 months ago (2011-05-15 19:07:58 UTC) #2

Expand All Messages | Collapse All Messages