Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 4515042: Making website build almost completely quiet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by PhilEHolmes
Modified:
8 years, 5 months ago
Reviewers:
Visibility:
Public.

Description

Making website build almost completely quiet Build updates to get rid of website warnings. These are used with the -s option (silent) in make website (i.e. make -s website). If used in this way, only geniune warnings and a few progress messages are displayed. Note that this patch includes the changes in the previous patch to reduce make website warnings (http://codereview.appspot.com/4428077/ Patch set 2).

Patch Set 1 #

Total comments: 13

Patch Set 2 : 2nd draft of quiet website build #

Total comments: 2

Patch Set 3 : Add a -q quiet flag to 'make website' scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M Documentation/lilypond-texi2html.init View 1 chunk +1 line, -1 line 0 comments Download
M make/website.make View 1 2 5 chunks +24 lines, -0 lines 0 comments Download
M scripts/build/bib2texi.py View 1 2 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/build/extract_texi_filenames.py View 1 6 chunks +12 lines, -5 lines 0 comments Download
M scripts/build/mass-link.py View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14
PhilEHolmes
8 years, 6 months ago (2011-05-08 15:09:02 UTC) #1
Graham Percival (old account)
looks basically good. http://codereview.appspot.com/4515042/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/4515042/diff/1/make/website.make#newcode8 make/website.make:8: quiet-run = $(findstring s, $(MAKEFLAGS)) I ...
8 years, 6 months ago (2011-05-11 21:58:34 UTC) #2
PhilEHolmes
Replies to Graham's comments. Not sure I've worked out how the review site does quoting ...
8 years, 6 months ago (2011-05-14 15:56:33 UTC) #3
Graham Percival (old account)
On 2011/05/14 15:56:33, PhilEHolmes wrote: > Replies to Graham's comments. Not sure I've worked out ...
8 years, 6 months ago (2011-05-15 07:08:51 UTC) #4
Graham Percival (old account)
On 2011/05/15 07:08:51, Graham Percival wrote: > ... wait a moment, this is your previous ...
8 years, 6 months ago (2011-05-15 07:10:07 UTC) #5
PhilEHolmes
2nd draft of quiet website build.
8 years, 6 months ago (2011-05-15 13:18:56 UTC) #6
Graham Percival (old account)
could we get a subject like "add a -q quiet flag to make websit scripts" ...
8 years, 6 months ago (2011-05-15 20:19:52 UTC) #7
mail_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, May 15, ...
8 years, 6 months ago (2011-05-25 15:44:59 UTC) #8
PhilEHolmes
Hopefully final patch.
8 years, 6 months ago (2011-05-25 15:45:31 UTC) #9
Graham Percival (old account)
LGTM
8 years, 6 months ago (2011-05-25 15:50:01 UTC) #10
mail_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com> Sent: Wednesday, May ...
8 years, 6 months ago (2011-05-25 16:02:53 UTC) #11
Graham Percival
On Wed, May 25, 2011 at 05:02:42PM +0100, Phil Holmes wrote: > Could you push, ...
8 years, 6 months ago (2011-05-25 16:06:47 UTC) #12
pacovila
2011/5/25 Graham Percival <graham@percival-music.ca>: > On Wed, May 25, 2011 at 05:02:42PM +0100, Phil Holmes ...
8 years, 6 months ago (2011-05-26 08:46:44 UTC) #13
Graham Percival (old account)
8 years, 5 months ago (2011-06-08 19:17:12 UTC) #14
I believe that this patch as pushed; could you please close the issue?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b