Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1638)

Issue 4514042: New partcombineUp and partcombineDown functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Bertrand Bordage
Modified:
7 years, 9 months ago
Reviewers:
pkx166h, dan
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New partcombineUp and partcombineDown functions Fix issue 1321

Patch Set 1 #

Patch Set 2 : Update and remove SCM/C boolean confusions. #

Patch Set 3 : Regtest added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -6 lines) Patch
A input/regression/part-combine-3voices.ly View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M lily/part-combine-iterator.cc View 1 5 chunks +31 lines, -4 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +15 lines, -1 line 0 comments Download
M scm/part-combiner.scm View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
pkx166h
When I try to patch to current tree (27 Aug) I get --snip-- patching file ...
7 years, 10 months ago (2011-08-27 08:04:38 UTC) #1
dan_faithful.be
On 2011-08-27, at 04:04 , pkx166h@gmail.com wrote: > When I try to patch to current ...
7 years, 10 months ago (2011-08-27 23:13:14 UTC) #2
Bertrand Bordage
I updated the patch and added a regtest. Dan, I don't have time for now ...
7 years, 9 months ago (2011-09-01 21:44:57 UTC) #3
dan_faithful.be
On 2011-09-01, at 17:44 , bordage.bertrand@gmail.com wrote: > I updated the patch and added a ...
7 years, 9 months ago (2011-09-01 23:04:50 UTC) #4
pkx166h
passes make and reg tests
7 years, 9 months ago (2011-09-24 20:16:13 UTC) #5
Bertrand Bordage
7 years, 9 months ago (2011-09-30 16:36:29 UTC) #6
Pushed as bb7cac7b276bd7d1335523f3be8df815cf894ece.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b