When I try to patch to current tree (27 Aug) I get --snip-- patching file ...
12 years, 7 months ago
(2011-08-27 08:04:38 UTC)
#1
When I try to patch to current tree (27 Aug) I get
--snip--
patching file lily/part-combine-iterator.cc
Hunk #2 succeeded at 138 with fuzz 1.
Hunk #4 FAILED at 390.
Hunk #5 FAILED at 412.
2 out of 5 hunks FAILED -- saving rejects to file
lily/part-combine-iterator.cc.rej
patching file ly/music-functions-init.ly
Hunk #1 succeeded at 762 (offset 29 lines).
patching file scm/part-combiner.scm
jlowe@jlowe-lilybuntu2:~/lilypond-git$
--snip--
Make succeeds though, and reg tests pass too.
So I have set this patch to 'review' as I don't know the significance of these
patch messages.
On 2011-08-27, at 04:04 , pkx166h@gmail.com wrote: > When I try to patch to current ...
12 years, 7 months ago
(2011-08-27 23:13:14 UTC)
#2
On 2011-08-27, at 04:04 , pkx166h@gmail.com wrote:
> When I try to patch to current tree (27 Aug) I get
>
> --snip--
> --snip--
>
> Make succeeds though, and reg tests pass too.
>
> So I have set this patch to 'review' as I don't know the significance of
> these patch messages.
>
> http://codereview.appspot.com/4514042/
Should there be a few new regression tests added along with this change that
cover the new \partcombineUp and \partcombineDown?
Also, this patch just seems to set some context properties in a round-about way.
Isn't it already possible to do that with something like...
\context Staff = "staffA"
<<
\partcombine \aNotes \bNotes
\context Voice = "one" % part combiner output
{
\override ...
}
>>
... as shown in the following patch submission from 2008, which was turned away
for not being flexible enough, even though it seems more flexible than the patch
under review? (Flexible from the standpoint that there are more distinct output
contexts that can be tweaked than in the current part combiner.)
http://lists.gnu.org/archive/html/lilypond-devel/2008-09/msg00079.html
--
Dan
I updated the patch and added a regtest. Dan, I don't have time for now ...
12 years, 7 months ago
(2011-09-01 21:44:57 UTC)
#3
I updated the patch and added a regtest.
Dan, I don't have time for now to rewrite the whole part combiner. Do you want
to do it ? If so, I can help you (at my level).
Bertrand
On 2011-09-01, at 17:44 , bordage.bertrand@gmail.com wrote: > I updated the patch and added a ...
12 years, 7 months ago
(2011-09-01 23:04:50 UTC)
#4
On 2011-09-01, at 17:44 , bordage.bertrand@gmail.com wrote:
> I updated the patch and added a regtest.
> Dan, I don't have time for now to rewrite the whole part combiner. Do
> you want to do it ? If so, I can help you (at my level).
I don't have time either. If this work is up to current standards, I'm not
going to complain. I just wanted to make known what was tried in the past.
--
Dan
Issue 4514042: New partcombineUp and partcombineDown functions
(Closed)
Created 12 years, 10 months ago by Bertrand Bordage
Modified 12 years, 6 months ago
Reviewers: pkx166h, dan_faithful.be
Base URL:
Comments: 0