Issue 44550043: code review 44550043: dashboard/builder: update benchmarks only between commits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44550043: code review 44550043: dashboard/builder: update benchmarks only between commits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dvyukov

Modified:
10 years, 3 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

dashboard/builder: update benchmarks only between commits It looks unnecessary to update benchmarks with go get -u between all benchmarks (i.e. every ~30 secs). Instead update benchmarks only between commits. TBR=adg

Patch Set 1 #

Patch Set 2 : diff -r 30176d54452e https://code.google.com/p/dvyukov-go-perf-dashboard #

Patch Set 3 : diff -r 30176d54452e https://code.google.com/p/dvyukov-go-perf-dashboard #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	dashboard/builder/bench.go	View	1	4 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dvyukov

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/dvyukov-go-perf-dashboard

10 years, 3 months ago (2013-12-24 17:21:06 UTC) #1

dvyukov

10 years, 3 months ago (2013-12-24 17:21:12 UTC) #2

*** Submitted as
https://code.google.com/p/dvyukov-go-perf-dashboard/source/detail?r=68941e8eb94a
***

dashboard/builder: update benchmarks only between commits
It looks unnecessary to update benchmarks with go get -u
between all benchmarks (i.e. every ~30 secs).
Instead update benchmarks only between commits.
TBR=adg

R=adg
CC=golang-dev
https://codereview.appspot.com/44550043

Expand All Messages | Collapse All Messages