Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(436)

Issue 4428077: Fix error messages in website build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by PhilEHolmes
Modified:
7 years, 11 months ago
Reviewers:
Graham Percival (old account), Trevor Daniels, Graham Percival, mail, t.daniels, email
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix error messages in website build

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated pacth to get rid of website build warnings #

Patch Set 3 : More changes to website build to make it quieter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
M Documentation/lilypond-texi2html.init View 1 2 1 chunk +1 line, -1 line 0 comments Download
M make/website.make View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
M scripts/build/bib2texi.py View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M scripts/build/extract_texi_filenames.py View 1 2 7 chunks +29 lines, -6 lines 0 comments Download
M scripts/build/mass-link.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A scripts/build/website-known-missing-files.txt View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 19
PhilEHolmes
I've at last uploaded a patch for review. This stops make website warning of missing ...
8 years ago (2011-05-02 15:12:57 UTC) #1
Graham Percival (old account)
good start! I'm not certain about the location of the text file (having it inside ...
8 years ago (2011-05-02 15:20:43 UTC) #2
mail_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Monday, May 02, ...
8 years ago (2011-05-02 16:29:36 UTC) #3
Graham Percival
On Mon, May 02, 2011 at 05:29:27PM +0100, Phil Holmes wrote: > >http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode65 > >scripts/build/extract_texi_filenames.py:65: ...
8 years ago (2011-05-02 17:28:26 UTC) #4
email_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; ...
8 years ago (2011-05-02 17:43:12 UTC) #5
Graham Percival (old account)
On 2011/05/02 17:43:12, email_philholmes.net wrote: > ----- Original Message ----- > From: "Graham Percival" <mailto:graham@percival-music.ca> ...
8 years ago (2011-05-02 18:19:29 UTC) #6
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; ...
8 years ago (2011-05-03 15:30:08 UTC) #7
Graham Percival
On Tue, May 03, 2011 at 04:29:58PM +0100, Phil Holmes wrote: > ----- Original Message ...
8 years ago (2011-05-04 23:10:22 UTC) #8
mail_philholmes.net
I've got a new patch - do you want to look at it on your ...
8 years ago (2011-05-05 12:37:54 UTC) #9
PhilEHolmes
An update to use lists rather than strings.
8 years ago (2011-05-05 21:19:39 UTC) #10
Graham Percival (old account)
LGTM
8 years ago (2011-05-05 21:30:21 UTC) #11
PhilEHolmes
I think this just about completes this, unless we want to get rid of the ...
8 years ago (2011-05-06 14:18:39 UTC) #12
Graham Percival (old account)
woah, this is confusing. Could go back to the 2nd draft patch, yesterday's version? That ...
8 years ago (2011-05-07 01:03:41 UTC) #13
Graham Percival (old account)
also, could we change the subject of the commit? (either by clever git stuff, or ...
8 years ago (2011-05-07 01:13:54 UTC) #14
c_sorensen
On 5/6/11 7:03 PM, "percival.music.ca@gmail.com" <percival.music.ca@gmail.com> wrote: > woah, this is confusing. > > Could ...
8 years ago (2011-05-07 01:13:54 UTC) #15
email_philholmes.net
----- Original Message ----- From: <percival.music.ca@gmail.com> To: <PhilEHolmes@googlemail.com>; <mail@philholmes.net>; <graham@percival-music.ca> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com> Sent: Saturday, ...
8 years ago (2011-05-07 09:39:21 UTC) #16
Graham Percival
On Sat, May 07, 2011 at 10:39:13AM +0100, Phil Holmes wrote: > OK. I'm not ...
8 years ago (2011-05-07 10:07:30 UTC) #17
Trevor Daniels
Patchset 2 LGTM. A more complete explanation of why this is needed should be included ...
8 years ago (2011-05-07 10:20:13 UTC) #18
t.daniels_treda.co.uk
8 years ago (2011-05-07 10:21:45 UTC) #19
Phil Holmes wrote Saturday, May 07, 2011 10:39 AM

> OK.  I'm not understanding how Rietveld works.  On my machine I 
> have 2 separate patches.  The first is the one you responded LGTM 
> to and I still have.  My aim was then to do some more work to get 
> rid of the rest of the warning, building on the previous patch.  I 
> did that, and fired it at Rietveld using git cl upload 
> origin/master.  Unexpectedly to me (since AFAICS it was brand new 
> work) it appeared as patch 3 at 
> http://codereview.appspot.com/4428077/.  I expected it to be a new 
> review.

The Reitfeld number is based on the git branch active
when git-cl upload origin/master is called.  All commits
on that branch not in origin/master will be coalesced
into a single patch and uploaded to Reitveld.  If there
has been a previous upload from that branch a new patchset
is added to the previous ones.  To generate a new Reitfeld
issue you need to place the commits in a new git branch.

> That said, if anyone wants to review my earlier effort, can't they 
> just review Patch 2 at http://codereview.appspot.com/4428077/ ?

Yes, although general comments would need to be prefixed
to indicate which patch set was being referenced.

> If we are OK with the initial patch, I can email it to someone to 
> push, and we could then review the new patch?

Sure - I could do that for you.

Trevor


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b