code review 4426066: ioutil: add Discard, update tree.

ioutil: add Discard, update tree.

This also removes an unnecessary allocation in
http/transfer.go

[bradfitz, 2011-04-27 21:46:47]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-04-27 22:02:00]

http://codereview.appspot.com/4426066/diff/5001/src/pkg/io/ioutil/ioutil.go
File src/pkg/io/ioutil/ioutil.go (right):

http://codereview.appspot.com/4426066/diff/5001/src/pkg/io/ioutil/ioutil.go#n...
src/pkg/io/ioutil/ioutil.go:111: // NopWriter is an io.Writer on which all Write
calls succeed
Not thrilled with the name. What about just Discard?

[bradfitz, 2011-04-27 22:25:43]

http://codereview.appspot.com/4426066/diff/5001/src/pkg/io/ioutil/ioutil.go
File src/pkg/io/ioutil/ioutil.go (right):

http://codereview.appspot.com/4426066/diff/5001/src/pkg/io/ioutil/ioutil.go#n...
src/pkg/io/ioutil/ioutil.go:111: // NopWriter is an io.Writer on which all Write
calls succeed
On 2011/04/27 22:02:00, r wrote:
> Not thrilled with the name. What about just Discard?

I don't care about the name. I picked NopWriter because it matched NopCloser
also in this package.

Your call.

[rsc1, 2011-04-27 22:29:12]

fmt.Fprintf(ioutil.Discard, "hello world")

looks good to me

[r2, 2011-04-27 22:37:03]

On Apr 27, 2011, at 3:29 PM, Russ Cox wrote:

> fmt.Fprintf(ioutil.Discard, "hello world")
> 
> looks good to me

i think the niceness of reading trumps the parallel with NopCloser (another name
i'm not thrilled with, although in that case i don't have a countersuggestion).

rename to Discard please.

-rob

[bradfitz, 2011-04-27 22:42:08]

Hello r, rsc1, r2 (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-04-27 22:42:55]

LGTM

nice

[adg, 2011-04-27 22:45:55]

See also ignoreWriter in archive/tar/reader.go

On 28 April 2011 08:42,  <r@golang.org> wrote:
> LGTM
>
> nice
>
>
> http://codereview.appspot.com/4426066/
>

[bradfitz, 2011-04-27 22:47:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=cb593b108aa5 ***

ioutil: add Discard, update tree.

This also removes an unnecessary allocation in
http/transfer.go

R=r, rsc1, r2, adg
CC=golang-dev
http://codereview.appspot.com/4426066

[bradfitzgoog, 2011-04-27 22:47:54]

whoops, just submitted before this came in.

On Wed, Apr 27, 2011 at 3:45 PM, Andrew Gerrand <adg@golang.org> wrote:

> See also ignoreWriter in archive/tar/reader.go
>
> On 28 April 2011 08:42,  <r@golang.org> wrote:
> > LGTM
> >
> > nice
> >
> >
> > http://codereview.appspot.com/4426066/
> >
>