Issue 44100043: code review 44100043: go/build: mention 'tag' as an alias for 'build constraint'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44100043: code review 44100043: go/build: mention 'tag' as an alias for 'build constraint' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by r

Modified:
10 years, 4 months ago

Reviewers:
adg, rsc

CC:
golang-dev, adg, rsc

Visibility:
Public.

Description

go/build: mention 'tag' as an alias for 'build constraint' The code is all about tags, and the cmd/go documentation said to look in the go/build documentation for information about tags, but the documentation said nothing about tags, only build constraints. Make things clearer.

Patch Set 1 #

Patch Set 2 : diff -r 5f52f1232b5d https://code.google.com/p/go #

Patch Set 3 : diff -r 1a494d6e192f https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	src/cmd/go/build.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/go/doc.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/build/doc.go	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2013-12-18 23:03:47 UTC) #1

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 4 months ago (2013-12-19 00:06:12 UTC) #3

10 years, 4 months ago (2013-12-19 19:43:37 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=5a3e576cfb56 ***

go/build: mention 'tag' as an alias for 'build constraint'
The code is all about tags, and the cmd/go documentation
said to look in the go/build documentation for information
about tags, but the documentation said nothing about tags,
only build constraints. Make things clearer.

R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/44100043

Expand All Messages | Collapse All Messages