Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 4398046: pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by Reinhold
Modified:
8 years, 5 months ago
Reviewers:
carl.d.sorensen, reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) All Latin1 metadata strings need to be printed out to the .ps file in Latin1 (or UTF-16BE, but definitely NOT in UTF-8), and all non-Latin1 strings need to use UTF-16BE encoding.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update patch to include the escaping of parentheses and backslashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
A input/regression/pdfmark-metadata-unicode.ly View 1 1 chunk +26 lines, -0 lines 0 comments Download
A lily/pdf-scheme.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5
Carl
THe structure of the patch looks good, but I think it conflicts with Bertrand's patch ...
8 years, 5 months ago (2011-04-14 21:14:25 UTC) #1
reinhold_kainhofer.com
On Do., 14. Apr. 2011 23:14:25 CEST, Carl.D.Sorensen@gmail.com wrote: > THe structure of the patch ...
8 years, 5 months ago (2011-04-14 22:52:04 UTC) #2
Carl
On 2011/04/14 22:52:04, reinhold_kainhofer.com wrote: > Yes, of course! As Graham wants to push Bertrand's ...
8 years, 5 months ago (2011-04-16 14:43:02 UTC) #3
Reinhold
On 2011/04/16 14:43:02, Carl wrote: > Bertrand's patch has now been pushed. If you can ...
8 years, 5 months ago (2011-04-16 17:40:17 UTC) #4
Carl
8 years, 5 months ago (2011-04-16 17:50:34 UTC) #5
LGTM

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b