Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7532)

Issue 4370051: Joomla master .htaccess - differences 2.4.4 - 3.1.l (r)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by g1smd
Modified:
12 years, 11 months ago
Reviewers:
nikosdion
Base URL:
http://joomla-master-htaccess.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Based on the version 2.3 code originally found at: http://snipt.net/nikosdion/the-master-htaccess/ and now listed at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn2&r=2 The original file contains a number of syntax errors, several rules that can never work, and a number of expressions that can be more efficiently coded. Bugs and enhancements originally discussed at: http://forum.joomla.org/viewtopic.php?f=432&t=549841 Discussion also at: http://snipt.net/nikosdion/the-master-htaccess/ and http://snipt.net/g1smd/joomla-patch/ The new 2.4.4 proposed file: http://snipt.net/g1smd/joomla-master-htaccess-file-proposed-v24-2011-04-07/ \[404]\ or at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn4&r=20 NOTE: this is not now the latest version of the file. Continued in: http://codereview.appspot.com/4314051/

Patch Set 1 : Joomla master .htaccess - differences 3.1.12 - 2.4.4 #

Total comments: 19
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -56 lines) Patch
joomla-master-htaccess.txt View 17 chunks +44 lines, -56 lines 19 comments Download

Messages

Total messages: 4
g1smd
http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt File joomla-master-htaccess.txt (left): http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#oldcode4 joomla-master-htaccess.txt:4: ## Version 3.1 - March 29th, 2010 2011. http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#oldcode228 ...
13 years ago (2011-04-10 00:00:18 UTC) #1
g1smd
http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt File joomla-master-htaccess.txt (left): http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#oldcode110 joomla-master-htaccess.txt:110: ## Suit to taste. No longer needed. http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt File ...
13 years ago (2011-04-10 08:44:34 UTC) #2
g1smd
http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt File joomla-master-htaccess.txt (left): http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#oldcode374 joomla-master-htaccess.txt:374: RewriteRule ^[^/]+\.php$ - [F] [^/]+ may well accidentally "consume" ...
13 years ago (2011-04-10 16:52:50 UTC) #3
g1smd
12 years, 11 months ago (2011-05-14 16:32:31 UTC) #4
http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt
File joomla-master-htaccess.txt (left):

http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#oldco...
joomla-master-htaccess.txt:368: # RewriteRule ^templates/([^.]+)\.php$ - [L]
The backreference is not required.

http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt
File joomla-master-htaccess.txt (right):

http://codereview.appspot.com/4370051/diff/3/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:363: ## Disallow access to htaccess.txt,
configuration.php, configuration.php-dist and php.ini
... and php.ini
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b